archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Restrict hover styles in action list to only href

Browse Source 
Summary: We're currently applying these styles to labels, restrict them to only list elements that have an href.

Test Plan: Test a label, an anchor, and a button as an action item.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D17031
This commit is contained in:
Chad Little
2016-12-12 09:04:03 -08:00
parent d8b028b51b
commit a79e4b786e
3 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
resources/celerity/map.php
View File

@@ -9,7 +9,7 @@ return array(
'names' => array( 'names' => array(
'conpherence.pkg.css' => '0b64e988', 'conpherence.pkg.css' => '0b64e988',
'conpherence.pkg.js' => '6249a1cf', 'conpherence.pkg.js' => '6249a1cf',
'core.pkg.css' => '1ef46ae8', 'core.pkg.css' => 'e18bf0da',
'core.pkg.js' => 'e4260032', 'core.pkg.js' => 'e4260032',
'darkconsole.pkg.js' => 'e7393ebb', 'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => 'a4ba74b5', 'differential.pkg.css' => 'a4ba74b5',
@@ -165,7 +165,7 @@ return array(
'rsrc/css/phui/phui-status.css' => 'd5263e49', 'rsrc/css/phui/phui-status.css' => 'd5263e49',
'rsrc/css/phui/phui-tag-view.css' => '6bbd83e2', 'rsrc/css/phui/phui-tag-view.css' => '6bbd83e2',
'rsrc/css/phui/phui-timeline-view.css' => 'bc523970', 'rsrc/css/phui/phui-timeline-view.css' => 'bc523970',
'rsrc/css/phui/phui-two-column-view.css' => 'ee61d056', 'rsrc/css/phui/phui-two-column-view.css' => 'f662d744',
'rsrc/css/phui/workboards/phui-workboard-color.css' => 'b60ef38a', 'rsrc/css/phui/workboards/phui-workboard-color.css' => 'b60ef38a',
'rsrc/css/phui/workboards/phui-workboard.css' => '16441d5e', 'rsrc/css/phui/workboards/phui-workboard.css' => '16441d5e',
'rsrc/css/phui/workboards/phui-workcard.css' => '0c62d7c5', 'rsrc/css/phui/workboards/phui-workcard.css' => '0c62d7c5',
@@ -882,7 +882,7 @@ return array(
'phui-tag-view-css' => '6bbd83e2', 'phui-tag-view-css' => '6bbd83e2',
'phui-theme-css' => '798c69b8', 'phui-theme-css' => '798c69b8',
'phui-timeline-view-css' => 'bc523970', 'phui-timeline-view-css' => 'bc523970',
'phui-two-column-view-css' => 'ee61d056', 'phui-two-column-view-css' => 'f662d744',
'phui-workboard-color-css' => 'b60ef38a', 'phui-workboard-color-css' => 'b60ef38a',
'phui-workboard-view-css' => '16441d5e', 'phui-workboard-view-css' => '16441d5e',
'phui-workcard-view-css' => '0c62d7c5', 'phui-workcard-view-css' => '0c62d7c5',

4
src/view/layout/PhabricatorActionView.php
View File

@@ -271,6 +271,10 @@ final class PhabricatorActionView extends AphrontView {
$classes[] = 'phabricator-action-view-submenu'; $classes[] = 'phabricator-action-view-submenu';
} }
if ($this->getHref()) {
$classes[] = 'phabricator-action-view-href';
}
$style = array(); $style = array();
if ($this->hidden) { if ($this->hidden) {

4
webroot/rsrc/css/phui/phui-two-column-view.css
View File

@@ -164,7 +164,7 @@
padding: 5px 4px 5px 28px; padding: 5px 4px 5px 28px;
} }
.device-desktop .phui-two-column-properties .phabricator-action-view:hover .device-desktop .phui-two-column-properties .phabricator-action-view-href:hover
.phabricator-action-view-item { .phabricator-action-view-item {
text-decoration: none; text-decoration: none;
background-color: rgba({$alphablue}, .08); background-color: rgba({$alphablue}, .08);
@@ -172,7 +172,7 @@
border-radius: 3px; border-radius: 3px;
} }
.device-desktop .phui-two-column-properties .phabricator-action-view:hover .device-desktop .phui-two-column-properties .phabricator-action-view-href:hover
.phabricator-action-view-icon { .phabricator-action-view-icon {
color: {$sky}; color: {$sky};
} }