archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Diffusion - return 404 errors for bad URIs

Browse Source 
Summary: Fixes T5646. Makes diffusion a much better user experience. Users now see a 404 exception page when they have a bad URI. Previously, they saw a developer-facing raw exception.

Test Plan: played around in diffusion a bunch. most of these changes were fairly mechanical at the end of the day.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T5646

Differential Revision: https://secure.phabricator.com/D11299
This commit is contained in:
Bob Trahan
2015-01-09 13:29:08 -08:00
parent 11a20079ef
commit a823654be0
45 changed files with 120 additions and 185 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/applications/diffusion/controller/DiffusionCommitController.php
View File

@@ -11,19 +11,18 @@ final class DiffusionCommitController extends DiffusionController {
return true;
}
public function willProcessRequest(array $data) {
// This controller doesn't use blob/path stuff, just pass the dictionary
// in directly instead of using the AphrontRequest parsing mechanism.
$data['user'] = $this->getRequest()->getUser();
$drequest = DiffusionRequest::newFromDictionary($data);
$this->diffusionRequest = $drequest;
protected function shouldLoadDiffusionRequest() {
return false;
}
public function processRequest() {
$drequest = $this->getDiffusionRequest();
$request = $this->getRequest();
protected function processDiffusionRequest(AphrontRequest $request) {
$user = $request->getUser();
// This controller doesn't use blob/path stuff, just pass the dictionary
// in directly instead of using the AphrontRequest parsing mechanism.
$data = $request->getURIMap();
$data['user'] = $user;
$drequest = DiffusionRequest::newFromDictionary($data);
$this->diffusionRequest = $drequest;
if ($request->getStr('diff')) {
return $this->buildRawDiffResponse($drequest);