Remove most callsites to Controller->renderHandlesForPHIDs()

Summary: Ref T7689. This moves most of the easy/testable callsites off `Controller->renderHandlesForPHIDs()`.

Test Plan:
- Viewed a file; viewed author; viewed "attached" tab.
- Viewed a mock; viewed attached tasks.
- Viewed a credential; viewed "Used By".
- Viewed a paste; viewed author; viewed forks; viewed forked from.
- Viewed a dashboard; viewed panel list.
- Viewed a dashboard panel; viewed "Appears On".
- Viewed a Phortune account; viewed "Members"; viewed payment methods.
- Viewed a Phortune merchant account; viewed "Members".
- Viewed Phortune account switcher; viewed "Accounts".
  - I just removed "Members:" here since it felt kind of out-of-place anyway.
- Viewed a Phragment fragment, viewed "Latest Version", viewed "Snapshots".
- Viewed a Phargment snapshot, viewed "Fragment".

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: hach-que, epriestley

Maniphest Tasks: T7689

Differential Revision: https://secure.phabricator.com/D12207

src/applications/files/controller/PhabricatorFileInfoController.php

@@ -39,11 +39,6 @@ final class PhabricatorFileInfoController extends PhabricatorFileController {
 
     $phid = $file->getPHID();
 
-    $handle_phids = array_merge(
-      array($file->getAuthorPHID()),
-      $file->getObjectPHIDs());
-
-    $this->loadHandles($handle_phids);
     $header = id(new PHUIHeaderView())
       ->setUser($user)
       ->setPolicyObject($file)
@@ -185,7 +180,6 @@ final class PhabricatorFileInfoController extends PhabricatorFileController {
     $request = $this->getRequest();
     $user = $request->getUser();
 
-
     $properties = id(new PHUIPropertyListView());
     $properties->setActionList($actions);
     $box->addPropertyList($properties, pht('Details'));
@@ -193,7 +187,7 @@ final class PhabricatorFileInfoController extends PhabricatorFileController {
     if ($file->getAuthorPHID()) {
       $properties->addProperty(
         pht('Author'),
-        $this->getHandle($file->getAuthorPHID())->renderLink());
+        $user->renderHandle($file->getAuthorPHID()));
     }
 
     $properties->addProperty(
@@ -270,7 +264,7 @@ final class PhabricatorFileInfoController extends PhabricatorFileController {
 
       $attached->addProperty(
         pht('Attached To'),
-        $this->renderHandlesForPHIDs($phids));
+        $user->renderHandleList($phids));
     }