Remove most callsites to Controller->renderHandlesForPHIDs()

Summary: Ref T7689. This moves most of the easy/testable callsites off `Controller->renderHandlesForPHIDs()`.

Test Plan:
- Viewed a file; viewed author; viewed "attached" tab.
- Viewed a mock; viewed attached tasks.
- Viewed a credential; viewed "Used By".
- Viewed a paste; viewed author; viewed forks; viewed forked from.
- Viewed a dashboard; viewed panel list.
- Viewed a dashboard panel; viewed "Appears On".
- Viewed a Phortune account; viewed "Members"; viewed payment methods.
- Viewed a Phortune merchant account; viewed "Members".
- Viewed Phortune account switcher; viewed "Accounts".
  - I just removed "Members:" here since it felt kind of out-of-place anyway.
- Viewed a Phragment fragment, viewed "Latest Version", viewed "Snapshots".
- Viewed a Phargment snapshot, viewed "Fragment".

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: hach-que, epriestley

Maniphest Tasks: T7689

Differential Revision: https://secure.phabricator.com/D12207

src/applications/pholio/controller/PholioMockViewController.php

@@ -42,8 +42,6 @@ final class PholioMockViewController extends PholioController {
       $mock->getPHID(),
       PholioMockHasTaskEdgeType::EDGECONST);
     $this->setManiphestTaskPHIDs($phids);
-    $phids[] = $mock->getAuthorPHID();
-    $this->loadHandles($phids);
 
     $engine = id(new PhabricatorMarkupEngine())
       ->setViewer($user);
@@ -167,7 +165,7 @@ final class PholioMockViewController extends PholioController {
 
     $properties->addProperty(
       pht('Author'),
-      $this->getHandle($mock->getAuthorPHID())->renderLink());
+      $user->renderHandle($mock->getAuthorPHID()));
 
     $properties->addProperty(
       pht('Created'),
@@ -176,7 +174,7 @@ final class PholioMockViewController extends PholioController {
     if ($this->getManiphestTaskPHIDs()) {
       $properties->addProperty(
         pht('Maniphest Tasks'),
-        $this->renderHandlesForPHIDs($this->getManiphestTaskPHIDs()));
+        $user->renderHandleList($this->getManiphestTaskPHIDs()));
     }
 
     $properties->invokeWillRenderEvent();