Don't require working copy to generate URIs in owners tool
Summary: Owners packages might include repositories that are no longer tracked (or checked out locally), and there's no reason why we need a working copy to generate a diffusion link. Instead of displaying a red error box, this diff allows the owners tool to render correctly. Test Plan: viewed /owners/view/all/ and /owners/package/395/ and verified no error box for not having a checkout of the repository. Reviewers: epriestley, vrana, wez Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3452
This commit is contained in:
@@ -98,13 +98,10 @@ final class PhabricatorOwnersDetailController
|
||||
$path_links = array();
|
||||
foreach ($paths as $path) {
|
||||
$repo = $repositories[$path->getRepositoryPHID()];
|
||||
$drequest = DiffusionRequest::newFromDictionary(
|
||||
$href = DiffusionRequest::generateDiffusionURI(
|
||||
array(
|
||||
'repository' => $repo,
|
||||
'callsign' => $repo->getCallsign(),
|
||||
'path' => $path->getPath(),
|
||||
));
|
||||
$href = $drequest->generateURI(
|
||||
array(
|
||||
'action' => 'browse'
|
||||
));
|
||||
$repo_name = '<strong>'.phutil_escape_html($repo->getName()).
|
||||
|
||||
@@ -262,13 +262,10 @@ final class PhabricatorOwnersListController
|
||||
foreach ($pkg_paths as $key => $path) {
|
||||
$repo = $repositories[$path->getRepositoryPHID()];
|
||||
if ($repo) {
|
||||
$drequest = DiffusionRequest::newFromDictionary(
|
||||
$href = DiffusionRequest::generateDiffusionURI(
|
||||
array(
|
||||
'repository' => $repo,
|
||||
'callsign' => $repo->getCallsign(),
|
||||
'path' => $path->getPath(),
|
||||
));
|
||||
$href = $drequest->generateURI(
|
||||
array(
|
||||
'action' => 'browse',
|
||||
));
|
||||
$pkg_paths[$key] =
|
||||
|
||||
Reference in New Issue
Block a user