Hide the Differential scroll objective list on trackpad systems
Summary: Ref T12733. In the longer run I'd like to just push this out from the edge, but that currently gets us into trouble since we start bumping into content. On my system, the trackpad scrollbar also expands in size when moused over, so the minimum number of pixels we need to push it out is approximatley 15px. This hits body content and the persistent chat. For now, just disable this element on trackpad systems. Test Plan: Disconnected all USB peripherals, quit and relaunched Safari, saw no objective list. Reconnected mouse, relaunched Safari, saw objective list. Reviewers: chad Reviewed By: chad Maniphest Tasks: T12733 Differential Revision: https://secure.phabricator.com/D17974
This commit is contained in:
@@ -5,6 +5,7 @@
|
||||
* javelin-stratcom
|
||||
* javelin-install
|
||||
* javelin-workflow
|
||||
* javelin-scrollbar
|
||||
* phabricator-scroll-objective
|
||||
* @javelin
|
||||
*/
|
||||
@@ -81,6 +82,11 @@ JX.install('ScrollObjectiveList', {
|
||||
|
||||
document.body.appendChild(node);
|
||||
|
||||
// If we're on OSX without a mouse or some other system with zero-width
|
||||
// trackpad-style scrollbars, adjust the display appropriately.
|
||||
var aesthetic = (JX.Scrollbar.getScrollbarControlWidth() === 0);
|
||||
JX.DOM.alterClass(node, 'has-aesthetic-scrollbar', aesthetic);
|
||||
|
||||
var d = JX.Vector.getDocument();
|
||||
|
||||
var list_dimensions = JX.Vector.getDim(node);
|
||||
|
||||
Reference in New Issue
Block a user