Remove shouldShowSubscribersProperty() from SubscribableInterface

Summary:
Every caller returns `true`. This was added a long time ago for Projects, but projects are no longer subscribable.

I don't anticipate needing this in the future.

Test Plan: Grepped for this method.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D15409

src/applications/badges/storage/PhabricatorBadgesBadge.php

@@ -181,10 +181,6 @@ final class PhabricatorBadgesBadge extends PhabricatorBadgesDAO
     return ($this->creatorPHID == $phid);
   }
 
-  public function shouldShowSubscribersProperty() {
-    return true;
-  }
-
 
 /* -(  PhabricatorTokenReceiverInterface  )---------------------------------- */
 

src/applications/calendar/storage/PhabricatorCalendarEvent.php

@@ -531,10 +531,6 @@ final class PhabricatorCalendarEvent extends PhabricatorCalendarDAO
     return ($phid == $this->getUserPHID());
   }
 
-  public function shouldShowSubscribersProperty() {
-    return true;
-  }
-
 /* -(  PhabricatorTokenReceiverInterface  )---------------------------------- */
 
 

src/applications/countdown/storage/PhabricatorCountdown.php

@@ -70,9 +70,6 @@ final class PhabricatorCountdown extends PhabricatorCountdownDAO
     return ($phid == $this->getAuthorPHID());
   }
 
-  public function shouldShowSubscribersProperty() {
-    return true;
-  }
 
 /* -(  PhabricatorApplicationTransactionInterface  )------------------------- */
 

src/applications/differential/storage/DifferentialRevision.php

@@ -485,10 +485,6 @@ final class DifferentialRevision extends DifferentialDAO
     return false;
   }
 
-  public function shouldShowSubscribersProperty() {
-    return true;
-  }
-
 
 /* -(  PhabricatorCustomFieldInterface  )------------------------------------ */
 

src/applications/files/storage/PhabricatorFile.php

@@ -1348,10 +1348,6 @@ final class PhabricatorFile extends PhabricatorFileDAO
     return ($this->authorPHID == $phid);
   }
 
-  public function shouldShowSubscribersProperty() {
-    return true;
-  }
-
 
 /* -(  PhabricatorTokenReceiverInterface  )---------------------------------- */
 

src/applications/fund/storage/FundInitiative.php

@@ -178,10 +178,6 @@ final class FundInitiative extends FundDAO
     return ($phid == $this->getOwnerPHID());
   }
 
-  public function shouldShowSubscribersProperty() {
-    return true;
-  }
-
 
 /* -(  PhabricatorTokenRecevierInterface  )---------------------------------- */
 

src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php

@@ -127,10 +127,6 @@ final class HarbormasterBuildPlan extends HarbormasterDAO
     return false;
   }
 
-  public function shouldShowSubscribersProperty() {
-    return true;
-  }
-
 
 /* -(  PhabricatorApplicationTransactionInterface  )------------------------- */
 

src/applications/herald/storage/HeraldRule.php

@@ -328,10 +328,6 @@ final class HeraldRule extends HeraldDAO
     return $this->isPersonalRule() && $phid == $this->getAuthorPHID();
   }
 
-  public function shouldShowSubscribersProperty() {
-    return true;
-  }
-
 
 /* -(  PhabricatorDestructibleInterface  )----------------------------------- */
 

src/applications/legalpad/storage/LegalpadDocument.php

@@ -163,10 +163,6 @@ final class LegalpadDocument extends LegalpadDAO
     return ($this->creatorPHID == $phid);
   }
 
-  public function shouldShowSubscribersProperty() {
-    return true;
-  }
-
 
 /* -(  PhabricatorPolicyInterface  )----------------------------------------- */
 

src/applications/macro/storage/PhabricatorFileImageMacro.php

@@ -111,10 +111,6 @@ final class PhabricatorFileImageMacro extends PhabricatorFileDAO
     return false;
   }
 
-  public function shouldShowSubscribersProperty() {
-    return true;
-  }
-
 
 /* -(  PhabricatorTokenRecevierInterface  )---------------------------------- */
 

src/applications/maniphest/storage/ManiphestTask.php

@@ -269,10 +269,6 @@ final class ManiphestTask extends ManiphestDAO
     return ($phid == $this->getOwnerPHID());
   }
 
-  public function shouldShowSubscribersProperty() {
-    return true;
-  }
-
 
 /* -(  Markup Interface  )--------------------------------------------------- */
 

src/applications/passphrase/storage/PassphraseCredential.php

@@ -157,10 +157,6 @@ final class PassphraseCredential extends PassphraseDAO
     return false;
   }
 
-  public function shouldShowSubscribersProperty() {
-    return true;
-  }
-
 
 /* -(  PhabricatorDestructibleInterface  )----------------------------------- */
 

src/applications/paste/storage/PhabricatorPaste.php

@@ -155,10 +155,6 @@ final class PhabricatorPaste extends PhabricatorPasteDAO
     return ($this->authorPHID == $phid);
   }
 
-  public function shouldShowSubscribersProperty() {
-    return true;
-  }
-
 
 /* -(  PhabricatorTokenReceiverInterface  )---------------------------------- */
 

src/applications/phame/storage/PhameBlog.php

@@ -336,10 +336,6 @@ final class PhameBlog extends PhameDAO
     return ($this->creatorPHID == $phid);
   }
 
-  public function shouldShowSubscribersProperty() {
-    return true;
-  }
-
 
 /* -(  PhabricatorConduitResultInterface  )---------------------------------- */
 

src/applications/phame/storage/PhamePost.php

@@ -282,10 +282,6 @@ final class PhamePost extends PhameDAO
     return ($this->bloggerPHID == $phid);
   }
 
-  public function shouldShowSubscribersProperty() {
-    return true;
-  }
-
 
 /* -(  PhabricatorConduitResultInterface  )---------------------------------- */
 

src/applications/pholio/storage/PholioMock.php

@@ -184,10 +184,6 @@ final class PholioMock extends PholioDAO
     return ($this->authorPHID == $phid);
   }
 
-  public function shouldShowSubscribersProperty() {
-    return true;
-  }
-
 
 /* -(  PhabricatorPolicyInterface Implementation  )-------------------------- */
 

src/applications/phriction/storage/PhrictionDocument.php

@@ -194,9 +194,6 @@ final class PhrictionDocument extends PhrictionDAO
     return false;
   }
 
-  public function shouldShowSubscribersProperty() {
-    return true;
-  }
 
 /* -(  PhabricatorApplicationTransactionInterface  )------------------------- */
 

src/applications/phurl/storage/PhabricatorPhurlURL.php

@@ -169,9 +169,6 @@ final class PhabricatorPhurlURL extends PhabricatorPhurlDAO
     return ($phid == $this->getAuthorPHID());
   }
 
-  public function shouldShowSubscribersProperty() {
-    return true;
-  }
 
 /* -(  PhabricatorTokenReceiverInterface  )---------------------------------- */
 

src/applications/ponder/storage/PonderAnswer.php

@@ -219,10 +219,6 @@ final class PonderAnswer extends PonderDAO
     return ($phid == $this->getAuthorPHID());
   }
 
-  public function shouldShowSubscribersProperty() {
-    return true;
-  }
-
 
 /* -(  PhabricatorDestructibleInterface  )----------------------------------- */
 

src/applications/ponder/storage/PonderQuestion.php

@@ -248,10 +248,6 @@ final class PonderQuestion extends PonderDAO
     return ($phid == $this->getAuthorPHID());
   }
 
-  public function shouldShowSubscribersProperty() {
-    return true;
-  }
-
 
 /* -(  PhabricatorTokenReceiverInterface  )---------------------------------- */
 

src/applications/repository/storage/PhabricatorRepositoryCommit.php

@@ -443,10 +443,6 @@ final class PhabricatorRepositoryCommit
     return ($phid == $this->getAuthorPHID());
   }
 
-  public function shouldShowSubscribersProperty() {
-    return true;
-  }
-
 
 /* -(  PhabricatorApplicationTransactionInterface  )------------------------- */
 

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

@@ -179,10 +179,6 @@ final class PhabricatorSlowvotePoll extends PhabricatorSlowvoteDAO
     return ($phid == $this->getAuthorPHID());
   }
 
-  public function shouldShowSubscribersProperty() {
-    return true;
-  }
-
 
 /* -(  PhabricatorTokenReceiverInterface  )---------------------------------- */
 

src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php

@@ -96,11 +96,6 @@ final class PhabricatorSubscriptionsUIEventListener
       return;
     }
 
-    if (!$object->shouldShowSubscribersProperty()) {
-      // This object doesn't render subscribers in its property list.
-      return;
-    }
-
     $subscribers = PhabricatorSubscribersQuery::loadSubscribersForPHID(
       $object->getPHID());
     if ($subscribers) {

src/applications/subscriptions/interface/PhabricatorSubscribableInterface.php

@@ -13,15 +13,6 @@ interface PhabricatorSubscribableInterface {
    */
   public function isAutomaticallySubscribed($phid);
 
-
-  /**
-   * Return `true` to indicate that "Subscribers:" should be shown when
-   * rendering property lists for this object, or `false` to omit the property.
-   *
-   * @return bool True to show the "Subscribers:" property.
-   */
-  public function shouldShowSubscribersProperty();
-
 }
 
 // TEMPLATE IMPLEMENTATION /////////////////////////////////////////////////////
@@ -33,8 +24,4 @@ interface PhabricatorSubscribableInterface {
     return false;
   }
 
-  public function shouldShowSubscribersProperty() {
-    return true;
-  }
-
 */

src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php

@@ -218,10 +218,6 @@ final class PhabricatorWorkerBulkJob
     return false;
   }
 
-  public function shouldShowSubscribersProperty() {
-    return true;
-  }
-
 
 /* -(  PhabricatorApplicationTransactionInterface  )------------------------- */