archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix a bug where too many changesets make it to display.

Browse Source 
Summary:

Test Plan:

Reviewers:

CC:
This commit is contained in:
epriestley
2011-03-07 22:01:33 -08:00
parent a100d97ed5
commit ad7a389106
4 changed files with 24 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/applications/base/controller/base/PhabricatorController.php
View File

@@ -56,7 +56,7 @@ abstract class PhabricatorController extends AphrontController {
}
if ($this->shouldRequireLogin() && !$user->getPHID()) {
$login_controller = new PhabricatorLoginController($request);
$login_controller = newv('PhabricatorLoginController', array($request));
return $this->delegateToController($login_controller);
}
}

3
src/applications/base/controller/base/__init__.php
View File

@@ -9,11 +9,12 @@
phutil_require_module('phabricator', 'aphront/console/core');
phutil_require_module('phabricator', 'aphront/controller');
phutil_require_module('phabricator', 'aphront/response/webpage');
phutil_require_module('phabricator', 'applications/auth/controller/login');
phutil_require_module('phabricator', 'applications/people/storage/user');
phutil_require_module('phabricator', 'infrastructure/env');
phutil_require_module('phabricator', 'storage/queryfx');
phutil_require_module('phabricator', 'view/page/standard');
phutil_require_module('phutil', 'utils');
phutil_require_source('PhabricatorController.php');

5
src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php
View File

@@ -54,7 +54,8 @@ class DifferentialRevisionViewController extends DifferentialController {
$this->getImplicitComments($revision),
$comments);
$inlines = $this->loadInlineComments($comments, $changesets);
$all_changesets = $changesets;
$inlines = $this->loadInlineComments($comments, $all_changesets);
$object_phids = array_merge(
$revision->getReviewers(),
@@ -116,7 +117,7 @@ class DifferentialRevisionViewController extends DifferentialController {
$comment_view->setComments($comments);
$comment_view->setHandles($handles);
$comment_view->setInlineComments($inlines);
$comment_view->setChangesets($changesets);
$comment_view->setChangesets($all_changesets);
$comment_view->setUser($user);
$diff_history = new DifferentialRevisionUpdateHistoryView();