archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix Ponder Answer query joins, builtins

Browse Source 
Summary: Fixes T9234. The joins method was still the old method and the builtin was calling the wrong key.

Test Plan: Test authored builtin, custom search

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T9234

Differential Revision: https://secure.phabricator.com/D13953
This commit is contained in:
Chad Little
2015-08-21 06:58:06 -07:00
parent 22dc3c1be2
commit ad93af8389
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/applications/ponder/query/PonderQuestionQuery.php
View File

@@ -129,7 +129,7 @@ final class PonderQuestionQuery
return $questions; return $questions;
} }
private function buildJoinsClause(AphrontDatabaseConnection $conn_r) { protected function buildJoinClauseParts(AphrontDatabaseConnection $conn_r) {
$joins = array(); $joins = array();
if ($this->answererPHIDs) { if ($this->answererPHIDs) {
@@ -141,7 +141,7 @@ final class PonderQuestionQuery
$this->answererPHIDs); $this->answererPHIDs);
} }
return implode(' ', $joins); return $joins;
} }
protected function getPrimaryTableAlias() { protected function getPrimaryTableAlias() {

2
src/applications/ponder/query/PonderQuestionSearchEngine.php
View File

@@ -96,7 +96,7 @@ final class PonderQuestionSearchEngine
array($this->requireViewer()->getPHID())); array($this->requireViewer()->getPHID()));
case 'answered': case 'answered':
return $query->setParameter( return $query->setParameter(
'answererPHIDs', 'answerers',
array($this->requireViewer()->getPHID())); array($this->requireViewer()->getPHID()));
} }