Use application PHIDs in Macro

Summary: Ref T2715. Move Macro to application PHIDs.

Test Plan: Used `conduit.query` to look up macros.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2715

Differential Revision: https://secure.phabricator.com/D6556

src/applications/macro/phid/PhabricatorMacroPHIDTypeMacro.php

@@ -0,0 +1,50 @@
+<?php
+
+final class PhabricatorMacroPHIDTypeMacro extends PhabricatorPHIDType {
+
+  const TYPECONST = 'MCRO';
+
+  public function getTypeConstant() {
+    return self::TYPECONST;
+  }
+
+  public function getTypeName() {
+    return pht('Image Macro');
+  }
+
+  public function newObject() {
+    return new PhabricatorFileImageMacro();
+  }
+
+  public function loadObjects(
+    PhabricatorObjectQuery $query,
+    array $phids) {
+
+    return id(new PhabricatorMacroQuery())
+      ->setViewer($query->getViewer())
+      ->withPHIDs($phids)
+      ->execute();
+  }
+
+  public function loadHandles(
+    PhabricatorHandleQuery $query,
+    array $handles,
+    array $objects) {
+
+    foreach ($handles as $phid => $handle) {
+      $macro = $objects[$phid];
+
+      $id = $macro->getID();
+      $name = $macro->getName();
+
+      $handle->setName($name);
+      $handle->setFullName(pht('Image Macro "%s"', $name));
+      $handle->setURI("/macro/view/{$id}/");
+    }
+  }
+
+  public function canLoadNamedObject($name) {
+    return false;
+  }
+
+}

src/applications/macro/storage/PhabricatorFileImageMacro.php

@@ -35,7 +35,7 @@ final class PhabricatorFileImageMacro extends PhabricatorFileDAO
 
   public function generatePHID() {
     return PhabricatorPHID::generateNewPHID(
-      PhabricatorPHIDConstants::PHID_TYPE_MCRO);
+      PhabricatorMacroPHIDTypeMacro::TYPECONST);
   }
 
   public function isAutomaticallySubscribed($phid) {

src/applications/macro/storage/PhabricatorMacroTransaction.php

@@ -12,7 +12,7 @@ final class PhabricatorMacroTransaction
   }
 
   public function getApplicationTransactionType() {
-    return PhabricatorPHIDConstants::PHID_TYPE_MCRO;
+    return PhabricatorMacroPHIDTypeMacro::TYPECONST;
   }
 
   public function getApplicationTransactionCommentObject() {