archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix some Releeph jankiness in interacting with the redesign

Browse Source 
Summary: Releeph does some really old sketchy stuff in result rendering. Modernize it, remove the holdover/oldschool interface (these were the last two implementors) and make errors a little softer.

Test Plan: Viewed Releeph products and branches.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D13604
This commit is contained in:
epriestley
2015-07-08 08:10:58 -07:00
parent 50491d2057
commit ae81f86a67
8 changed files with 153 additions and 166 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/applications/search/controller/PhabricatorApplicationSearchController.php
View File

@@ -217,18 +217,16 @@ final class PhabricatorApplicationSearchController
$objects = $engine->executeQuery($query, $pager);
// TODO: To support Dashboard panels, rendering is moving into
// SearchEngines. Move it all the way in and then get rid of this.
$engine->setRequest($request);
$list = $engine->renderResults($objects, $saved_query);
$interface = 'PhabricatorApplicationSearchResultsControllerInterface';
if ($parent instanceof $interface) {
$list = $parent->renderResultsList($objects, $saved_query);
} else {
$engine->setRequest($request);
$list = $engine->renderResults(
$objects,
$saved_query);
if (!($list instanceof PhabricatorApplicationSearchResultView)) {
throw new Exception(
pht(
'SearchEngines must render a "%s" object, but this engine '.
'(of class "%s") rendered something else.',
'PhabricatorApplicationSearchResultView',
get_class($engine)));
}
if ($list->getActions()) {