Add a preference to completely disable the file tree
Summary: See D4812. - This preference disables the file tree completely. - It defaults off, so users who want it will have to go turn it on. - Maybe slightly cleaner would be doing this if the tree was hidden and then ajaxing it in if you press "F", but that's complicated and I don't want to bother. - Generally, I think this element is useful to something like 5% of users and not useful to 95%. Test Plan: Enabled and disabled file tree. Looked at commits and revisions; verified they reflected the setting correctly. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D4813
This commit is contained in:
@@ -408,34 +408,42 @@ final class DifferentialRevisionViewController extends DifferentialController {
|
||||
->setAnchorName('top')
|
||||
->setNavigationMarker(true);
|
||||
|
||||
$collapsed = $user->loadPreferences()->getPreference(
|
||||
PhabricatorUserPreferences::PREFERENCE_NAV_COLLAPSED,
|
||||
false);
|
||||
|
||||
$nav = id(new DifferentialChangesetFileTreeSideNavBuilder())
|
||||
->setAnchorName('top')
|
||||
->setTitle('D'.$revision->getID())
|
||||
->setBaseURI(new PhutilURI('/D'.$revision->getID()))
|
||||
->setCollapsed((bool)$collapsed)
|
||||
->build($changesets);
|
||||
$nav->appendChild(
|
||||
array(
|
||||
$reviewer_warning,
|
||||
$top_anchor,
|
||||
$revision_detail,
|
||||
$page_pane,
|
||||
));
|
||||
|
||||
$content = array(
|
||||
$reviewer_warning,
|
||||
$top_anchor,
|
||||
$revision_detail,
|
||||
$page_pane,
|
||||
);
|
||||
|
||||
$crumbs = $this->buildApplicationCrumbs();
|
||||
$crumbs->addCrumb(
|
||||
id(new PhabricatorCrumbView())
|
||||
->setName($object_id)
|
||||
->setHref('/'.$object_id));
|
||||
$nav->setCrumbs($crumbs);
|
||||
|
||||
$prefs = $user->loadPreferences();
|
||||
|
||||
$pref_filetree = PhabricatorUserPreferences::PREFERENCE_DIFF_FILETREE;
|
||||
if ($prefs->getPreference($pref_filetree)) {
|
||||
$collapsed = $prefs->getPreference(
|
||||
PhabricatorUserPreferences::PREFERENCE_NAV_COLLAPSED,
|
||||
false);
|
||||
|
||||
$nav = id(new DifferentialChangesetFileTreeSideNavBuilder())
|
||||
->setAnchorName('top')
|
||||
->setTitle('D'.$revision->getID())
|
||||
->setBaseURI(new PhutilURI('/D'.$revision->getID()))
|
||||
->setCollapsed((bool)$collapsed)
|
||||
->build($changesets);
|
||||
$nav->appendChild($content);
|
||||
$nav->setCrumbs($crumbs);
|
||||
$content = $nav;
|
||||
} else {
|
||||
array_unshift($content, $crumbs);
|
||||
}
|
||||
|
||||
return $this->buildApplicationPage(
|
||||
$nav,
|
||||
$content,
|
||||
array(
|
||||
'title' => $object_id.' '.$revision->getTitle(),
|
||||
));
|
||||
|
||||
Reference in New Issue
Block a user