Move all account link / unlink to new registration flow

Summary: Ref T1536. Currently, we have separate panels for each link/unlink and separate controllers for OAuth vs LDAP. Instead, provide a single "External Accounts" panel which shows all linked accounts and allows you to link/unlink more easily. Move link/unlink over to a full externalaccount-based workflow. Test Plan: - Linked and unlinked OAuth accounts. - Linked and unlinked LDAP accounts. - Registered new accounts. - Exercised most/all of the error cases. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran, mbishopim3 Maniphest Tasks: T1536 Differential Revision: https://secure.phabricator.com/D6189
2013-06-17 06:12:45 -07:00
parent 61a0c6d6e3
commit b040f889de
24 changed files with 691 additions and 530 deletions
--- a/src/applications/auth/controller/PhabricatorAuthLinkController.php
+++ b/src/applications/auth/controller/PhabricatorAuthLinkController.php
@@ -0,0 +1,81 @@
+<?php
+
+final class PhabricatorAuthLinkController
+  extends PhabricatorAuthController {
+
+  private $providerKey;
+
+  public function willProcessRequest(array $data) {
+    $this->providerKey = $data['pkey'];
+  }
+
+  public function processRequest() {
+    $request = $this->getRequest();
+    $viewer = $request->getUser();
+
+    $provider = PhabricatorAuthProvider::getEnabledProviderByKey(
+      $this->providerKey);
+    if (!$provider) {
+      return new Aphront404Response();
+    }
+
+    if (!$provider->shouldAllowAccountLink()) {
+      return $this->renderErrorPage(
+        pht('Account Not Linkable'),
+        array(
+          pht('This provider is not configured to allow linking.'),
+        ));
+    }
+
+    $account = id(new PhabricatorExternalAccount())->loadOneWhere(
+      'accountType = %s AND accountDomain = %s AND userPHID = %s',
+      $provider->getProviderType(),
+      $provider->getProviderDomain(),
+      $viewer->getPHID());
+    if ($account) {
+      return $this->renderErrorPage(
+        pht('Account Already Linked'),
+        array(
+          pht(
+            'Your Phabricator account is already linked to an external '.
+            'account for this provider.'),
+        ));
+    }
+
+    $panel_uri = '/settings/panel/external/';
+
+    $request->setCookie('phcid', Filesystem::readRandomCharacters(16));
+    $form = $provider->buildLinkForm($this);
+
+    if ($provider->isLoginFormAButton()) {
+      require_celerity_resource('auth-css');
+      $form = phutil_tag(
+        'div',
+        array(
+          'class' => 'phabricator-link-button pl',
+        ),
+        $form);
+    }
+
+    $crumbs = $this->buildApplicationCrumbs();
+    $crumbs->addCrumb(
+      id(new PhabricatorCrumbView())
+        ->setName(pht('Link Account'))
+        ->setHref($panel_uri));
+    $crumbs->addCrumb(
+      id(new PhabricatorCrumbView())
+        ->setName($provider->getProviderName()));
+
+    return $this->buildApplicationPage(
+      array(
+        $crumbs,
+        $form,
+      ),
+      array(
+        'title' => pht('Link %s Account', $provider->getProviderName()),
+        'dust' => true,
+        'device' => true,
+      ));
+  }
+
+}