Ponder - make feed stories and emails a bit better

Summary: Also some random cleanup now and again. Note reply handler stuff is kind of bojangles bad right now. It didn't work before though either so hey.

Test Plan: asked questions, answered questions, edited answers... the feed pleased my eye

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, aran

Maniphest Tasks: T3653

Differential Revision: https://secure.phabricator.com/D7027

src/applications/ponder/controller/PonderAnswerEditController.php

@@ -31,9 +31,8 @@ final class PonderAnswerEditController extends PonderController {
 
     $question = $answer->getQuestion();
     $qid = $question->getID();
-    $aid = $answer->getID();
 
-    $question_uri = "/Q{$qid}#A{$aid}";
+    $answer_uri = $answer->getURI();
 
     $errors = array();
     if ($request->isFormPost()) {
@@ -58,7 +57,7 @@ final class PonderAnswerEditController extends PonderController {
         $editor->applyTransactions($answer, $xactions);
 
         return id(new AphrontRedirectResponse())
-          ->setURI($question_uri);
+          ->setURI($answer_uri);
       }
     }
 
@@ -84,13 +83,13 @@ final class PonderAnswerEditController extends PonderController {
       ->appendChild(
         id(new AphrontFormSubmitControl())
           ->setValue(pht('Update Answer'))
-          ->addCancelButton($question_uri));
+          ->addCancelButton($answer_uri));
 
     $crumbs = $this->buildApplicationCrumbs();
     $crumbs->addCrumb(
       id(new PhabricatorCrumbView())
         ->setName("Q{$qid}")
-        ->setHref($question_uri));
+        ->setHref($answer_uri));
     $crumbs->addCrumb(
       id(new PhabricatorCrumbView())
         ->setName(pht('Edit Answer')));