Clean up display of clone URIs a little bit

Summary:
Ref T10923. This makes the "Clone URI" UI a little nicer:

  - Show whether each URI is read-only, read-write, or external.
  - Clicking the button selects the URI.
  - Add a link to manage the appropriate credentials.

Test Plan: {F1308302, size=full}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10923

Differential Revision: https://secure.phabricator.com/D15891

src/applications/diffusion/controller/DiffusionRepositoryController.php

@@ -669,8 +669,6 @@ final class DiffusionRepositoryController extends DiffusionController {
     PhabricatorRepository $repository,
     PhabricatorRepositoryURI $uri) {
 
-    require_celerity_resource('diffusion-icons-css');
-
     if ($repository->isSVN()) {
       $display = csprintf(
         'svn checkout %R %R',
@@ -681,17 +679,13 @@ final class DiffusionRepositoryController extends DiffusionController {
     }
 
     $display = (string)$display;
+    $viewer = $this->getViewer();
 
-    $input = javelin_tag(
-      'input',
-      array(
-        'type' => 'text',
-        'value' => $display,
-        'class' => 'diffusion-clone-uri',
-        'readonly' => 'true',
-      ));
-
-    return $input;
+    return id(new DiffusionCloneURIView())
+      ->setViewer($viewer)
+      ->setRepository($repository)
+      ->setRepositoryURI($uri)
+      ->setDisplayURI($display);
   }
 
 }