Add "final" to all Phabricator "Controller" classes

Summary: These are all unambiguously unextensible. Issues I hit: - Maniphest Change/Diff controllers, just consolidated them. - Some search controllers incorrectly extend from "Search" but should extend from "SearchBase". This has no runtime effects. - D1836 introduced a closure, which we don't handle correctly (somewhat on purpose; we target PHP 5.2). See T962. Test Plan: Ran "testEverythingImplemented" unit test to identify classes extending from `final` classes. Resolved issues. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T795 Differential Revision: https://secure.phabricator.com/D1843
2012-03-09 15:46:25 -08:00
parent 1bff43a0c3
commit b2890eeb0e
158 changed files with 276 additions and 273 deletions
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -422,7 +422,6 @@ phutil_register_library_map(array(
    'ManiphestTask' => 'applications/maniphest/storage/task',
    'ManiphestTaskAuxiliaryStorage' => 'applications/maniphest/storage/auxiliary',
    'ManiphestTaskDescriptionChangeController' => 'applications/maniphest/controller/descriptionchange',
-    'ManiphestTaskDescriptionDiffController' => 'applications/maniphest/controller/descriptiondiff',
    'ManiphestTaskDescriptionPreviewController' => 'applications/maniphest/controller/descriptionpreview',
    'ManiphestTaskDetailController' => 'applications/maniphest/controller/taskdetail',
    'ManiphestTaskEditController' => 'applications/maniphest/controller/taskedit',
@@ -1232,7 +1231,6 @@ phutil_register_library_map(array(
    'ManiphestTask' => 'ManiphestDAO',
    'ManiphestTaskAuxiliaryStorage' => 'ManiphestDAO',
    'ManiphestTaskDescriptionChangeController' => 'ManiphestController',
-    'ManiphestTaskDescriptionDiffController' => 'ManiphestTaskDescriptionChangeController',
    'ManiphestTaskDescriptionPreviewController' => 'ManiphestController',
    'ManiphestTaskDetailController' => 'ManiphestController',
    'ManiphestTaskEditController' => 'ManiphestController',
@@ -1522,7 +1520,7 @@ phutil_register_library_map(array(
    'PhabricatorRepositorySymbol' => 'PhabricatorRepositoryDAO',
    'PhabricatorRepositoryTestCase' => 'PhabricatorTestCase',
    'PhabricatorS3FileStorageEngine' => 'PhabricatorFileStorageEngine',
-    'PhabricatorSearchAttachController' => 'PhabricatorSearchController',
+    'PhabricatorSearchAttachController' => 'PhabricatorSearchBaseController',
    'PhabricatorSearchBaseController' => 'PhabricatorController',
    'PhabricatorSearchCommitIndexer' => 'PhabricatorSearchDocumentIndexer',
    'PhabricatorSearchController' => 'PhabricatorSearchBaseController',
@@ -1537,7 +1535,7 @@ phutil_register_library_map(array(
    'PhabricatorSearchPhrictionIndexer' => 'PhabricatorSearchDocumentIndexer',
    'PhabricatorSearchQuery' => 'PhabricatorSearchDAO',
    'PhabricatorSearchResultView' => 'AphrontView',
-    'PhabricatorSearchSelectController' => 'PhabricatorSearchController',
+    'PhabricatorSearchSelectController' => 'PhabricatorSearchBaseController',
    'PhabricatorSearchUserIndexer' => 'PhabricatorSearchDocumentIndexer',
    'PhabricatorSlowvoteChoice' => 'PhabricatorSlowvoteDAO',
    'PhabricatorSlowvoteComment' => 'PhabricatorSlowvoteDAO',
--- a/src/aphront/console/controller/DarkConsoleController.php
+++ b/src/aphront/console/controller/DarkConsoleController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -19,7 +19,7 @@
 /**
 * @group console
 */
-class DarkConsoleController extends PhabricatorController {
+final class DarkConsoleController extends PhabricatorController {

  protected $op;
  protected $data;
--- a/src/aphront/default/configuration/AphrontDefaultApplicationConfiguration.php
+++ b/src/aphront/default/configuration/AphrontDefaultApplicationConfiguration.php
@@ -196,10 +196,8 @@ class AphrontDefaultApplicationConfiguration
        'task/' => array(
          'create/' => 'ManiphestTaskEditController',
          'edit/(?P<id>\d+)/' => 'ManiphestTaskEditController',
-          'descriptionchange/(?P<id>\d+)/' =>
+          'descriptionchange/(?:(?P<id>\d+)/)?' =>
            'ManiphestTaskDescriptionChangeController',
-          'descriptiondiff/' =>
-            'ManiphestTaskDescriptionDiffController',
          'descriptionpreview/' =>
            'ManiphestTaskDescriptionPreviewController',
        ),
--- a/src/applications/auth/controller/disabled/PhabricatorDisabledUserController.php
+++ b/src/applications/auth/controller/disabled/PhabricatorDisabledUserController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,8 @@
 * limitations under the License.
 */

-class PhabricatorDisabledUserController extends PhabricatorAuthController {
+final class PhabricatorDisabledUserController
+  extends PhabricatorAuthController {

  public function shouldRequireEnabledUser() {
    return false;
--- a/src/applications/auth/controller/email/PhabricatorEmailLoginController.php
+++ b/src/applications/auth/controller/email/PhabricatorEmailLoginController.php
@@ -16,7 +16,8 @@
 * limitations under the License.
 */

-class PhabricatorEmailLoginController extends PhabricatorAuthController {
+final class PhabricatorEmailLoginController
+  extends PhabricatorAuthController {

  public function shouldRequireLogin() {
    return false;
--- a/src/applications/auth/controller/emailtoken/PhabricatorEmailTokenController.php
+++ b/src/applications/auth/controller/emailtoken/PhabricatorEmailTokenController.php
@@ -16,7 +16,8 @@
 * limitations under the License.
 */

-class PhabricatorEmailTokenController extends PhabricatorAuthController {
+final class PhabricatorEmailTokenController
+  extends PhabricatorAuthController {

  private $token;

--- a/src/applications/auth/controller/login/PhabricatorLoginController.php
+++ b/src/applications/auth/controller/login/PhabricatorLoginController.php
@@ -16,7 +16,8 @@
 * limitations under the License.
 */

-class PhabricatorLoginController extends PhabricatorAuthController {
+final class PhabricatorLoginController
+  extends PhabricatorAuthController {

  public function shouldRequireLogin() {
    return false;
--- a/src/applications/auth/controller/logout/PhabricatorLogoutController.php
+++ b/src/applications/auth/controller/logout/PhabricatorLogoutController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,8 @@
 * limitations under the License.
 */

-class PhabricatorLogoutController extends PhabricatorAuthController {
+final class PhabricatorLogoutController
+  extends PhabricatorAuthController {

  public function shouldRequireLogin() {
    return true;
--- a/src/applications/auth/controller/oauth/PhabricatorOAuthLoginController.php
+++ b/src/applications/auth/controller/oauth/PhabricatorOAuthLoginController.php
@@ -16,7 +16,8 @@
 * limitations under the License.
 */

-class PhabricatorOAuthLoginController extends PhabricatorAuthController {
+final class PhabricatorOAuthLoginController
+  extends PhabricatorAuthController {

  private $provider;
  private $userID;
--- a/src/applications/auth/controller/oauthdiagnostics/PhabricatorOAuthDiagnosticsController.php
+++ b/src/applications/auth/controller/oauthdiagnostics/PhabricatorOAuthDiagnosticsController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorOAuthDiagnosticsController
+final class PhabricatorOAuthDiagnosticsController
  extends PhabricatorAuthController {

  public function shouldRequireLogin() {
--- a/src/applications/auth/controller/oauthregistration/default/PhabricatorOAuthDefaultRegistrationController.php
+++ b/src/applications/auth/controller/oauthregistration/default/PhabricatorOAuthDefaultRegistrationController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorOAuthDefaultRegistrationController
+final class PhabricatorOAuthDefaultRegistrationController
  extends PhabricatorOAuthRegistrationController {

  public function processRequest() {
--- a/src/applications/auth/controller/refresh/PhabricatorRefreshCSRFController.php
+++ b/src/applications/auth/controller/refresh/PhabricatorRefreshCSRFController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorRefreshCSRFController extends PhabricatorAuthController {
+final class PhabricatorRefreshCSRFController extends PhabricatorAuthController {

  public function processRequest() {
    $request = $this->getRequest();
--- a/src/applications/auth/controller/unlink/PhabricatorOAuthUnlinkController.php
+++ b/src/applications/auth/controller/unlink/PhabricatorOAuthUnlinkController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorOAuthUnlinkController extends PhabricatorAuthController {
+final class PhabricatorOAuthUnlinkController extends PhabricatorAuthController {

  private $provider;

--- a/src/applications/auth/controller/validate/PhabricatorLoginValidateController.php
+++ b/src/applications/auth/controller/validate/PhabricatorLoginValidateController.php
@@ -16,7 +16,8 @@
 * limitations under the License.
 */

-class PhabricatorLoginValidateController extends PhabricatorAuthController {
+final class PhabricatorLoginValidateController
+  extends PhabricatorAuthController {

  public function shouldRequireLogin() {
    return false;
--- a/src/applications/base/controller/404/Phabricator404Controller.php
+++ b/src/applications/base/controller/404/Phabricator404Controller.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class Phabricator404Controller extends PhabricatorController {
+final class Phabricator404Controller extends PhabricatorController {

  public function processRequest() {
    return new Aphront404Response();
--- a/src/applications/base/controller/redirect/PhabricatorRedirectController.php
+++ b/src/applications/base/controller/redirect/PhabricatorRedirectController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorRedirectController extends PhabricatorController {
+final class PhabricatorRedirectController extends PhabricatorController {

  private $uri;

--- a/src/applications/calendar/controller/browse/PhabricatorCalendarBrowseController.php
+++ b/src/applications/calendar/controller/browse/PhabricatorCalendarBrowseController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorCalendarBrowseController
+final class PhabricatorCalendarBrowseController
  extends PhabricatorCalendarController {

  public function processRequest() {
--- a/src/applications/conduit/controller/api/PhabricatorConduitAPIController.php
+++ b/src/applications/conduit/controller/api/PhabricatorConduitAPIController.php
@@ -19,7 +19,7 @@
 /**
 * @group conduit
 */
-class PhabricatorConduitAPIController
+final class PhabricatorConduitAPIController
  extends PhabricatorConduitController {

  public function shouldRequireLogin() {
--- a/src/applications/conduit/controller/console/PhabricatorConduitConsoleController.php
+++ b/src/applications/conduit/controller/console/PhabricatorConduitConsoleController.php
@@ -19,7 +19,7 @@
 /**
 * @group conduit
 */
-class PhabricatorConduitConsoleController
+final class PhabricatorConduitConsoleController
  extends PhabricatorConduitController {

  private $method;
--- a/src/applications/conduit/controller/log/PhabricatorConduitLogController.php
+++ b/src/applications/conduit/controller/log/PhabricatorConduitLogController.php
@@ -19,7 +19,8 @@
 /**
 * @group conduit
 */
-class PhabricatorConduitLogController extends PhabricatorConduitController {
+final class PhabricatorConduitLogController
+  extends PhabricatorConduitController {

  public function processRequest() {
    $request = $this->getRequest();
--- a/src/applications/conduit/controller/token/PhabricatorConduitTokenController.php
+++ b/src/applications/conduit/controller/token/PhabricatorConduitTokenController.php
@@ -19,7 +19,8 @@
 /**
 * @group conduit
 */
-class PhabricatorConduitTokenController extends PhabricatorConduitController {
+final class PhabricatorConduitTokenController
+  extends PhabricatorConduitController {

  public function processRequest() {

--- a/src/applications/countdown/controller/delete/PhabricatorCountdownDeleteController.php
+++ b/src/applications/countdown/controller/delete/PhabricatorCountdownDeleteController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorCountdownDeleteController
+final class PhabricatorCountdownDeleteController
  extends PhabricatorCountdownController {

  public function willProcessRequest(array $data) {
--- a/src/applications/countdown/controller/edit/PhabricatorCountdownEditController.php
+++ b/src/applications/countdown/controller/edit/PhabricatorCountdownEditController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorCountdownEditController
+final class PhabricatorCountdownEditController
  extends PhabricatorCountdownController {

  private $id;
--- a/src/applications/countdown/controller/list/PhabricatorCountdownListController.php
+++ b/src/applications/countdown/controller/list/PhabricatorCountdownListController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorCountdownListController
+final class PhabricatorCountdownListController
  extends PhabricatorCountdownController {

  public function processRequest() {
--- a/src/applications/countdown/controller/view/PhabricatorCountdownViewController.php
+++ b/src/applications/countdown/controller/view/PhabricatorCountdownViewController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorCountdownViewController
+final class PhabricatorCountdownViewController
  extends PhabricatorCountdownController {

  private $id;
--- a/src/applications/daemon/controller/combined/PhabricatorDaemonCombinedLogController.php
+++ b/src/applications/daemon/controller/combined/PhabricatorDaemonCombinedLogController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorDaemonCombinedLogController
+final class PhabricatorDaemonCombinedLogController
  extends PhabricatorDaemonController {


--- a/src/applications/daemon/controller/console/PhabricatorDaemonConsoleController.php
+++ b/src/applications/daemon/controller/console/PhabricatorDaemonConsoleController.php
@@ -16,7 +16,8 @@
 * limitations under the License.
 */

-class PhabricatorDaemonConsoleController extends PhabricatorDaemonController {
+final class PhabricatorDaemonConsoleController
+  extends PhabricatorDaemonController {

  public function processRequest() {
    $logs = id(new PhabricatorDaemonLog())->loadAllWhere(
--- a/src/applications/daemon/controller/loglist/PhabricatorDaemonLogListController.php
+++ b/src/applications/daemon/controller/loglist/PhabricatorDaemonLogListController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,8 @@
 * limitations under the License.
 */

-class PhabricatorDaemonLogListController extends PhabricatorDaemonController {
+final class PhabricatorDaemonLogListController
+  extends PhabricatorDaemonController {

  public function processRequest() {
    $request = $this->getRequest();
--- a/src/applications/daemon/controller/logview/PhabricatorDaemonLogViewController.php
+++ b/src/applications/daemon/controller/logview/PhabricatorDaemonLogViewController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,8 @@
 * limitations under the License.
 */

-class PhabricatorDaemonLogViewController extends PhabricatorDaemonController {
+final class PhabricatorDaemonLogViewController
+  extends PhabricatorDaemonController {

  private $id;

--- a/src/applications/daemon/controller/timeline/PhabricatorDaemonTimelineConsoleController.php
+++ b/src/applications/daemon/controller/timeline/PhabricatorDaemonTimelineConsoleController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorDaemonTimelineConsoleController
+final class PhabricatorDaemonTimelineConsoleController
  extends PhabricatorDaemonController {

  public function processRequest() {
--- a/src/applications/daemon/controller/timelineevent/PhabricatorDaemonTimelineEventController.php
+++ b/src/applications/daemon/controller/timelineevent/PhabricatorDaemonTimelineEventController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorDaemonTimelineEventController
+final class PhabricatorDaemonTimelineEventController
  extends PhabricatorDaemonController {

  private $id;
--- a/src/applications/daemon/controller/workertaskdetail/PhabricatorWorkerTaskDetailController.php
+++ b/src/applications/daemon/controller/workertaskdetail/PhabricatorWorkerTaskDetailController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorWorkerTaskDetailController
+final class PhabricatorWorkerTaskDetailController
  extends PhabricatorDaemonController {

  private $id;
--- a/src/applications/daemon/controller/workertaskupdate/PhabricatorWorkerTaskUpdateController.php
+++ b/src/applications/daemon/controller/workertaskupdate/PhabricatorWorkerTaskUpdateController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorWorkerTaskUpdateController
+final class PhabricatorWorkerTaskUpdateController
  extends PhabricatorDaemonController {

  private $id;
--- a/src/applications/differential/controller/changesetview/DifferentialChangesetViewController.php
+++ b/src/applications/differential/controller/changesetview/DifferentialChangesetViewController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class DifferentialChangesetViewController extends DifferentialController {
+final class DifferentialChangesetViewController extends DifferentialController {


  public function shouldRequireLogin() {
--- a/src/applications/differential/controller/commentpreview/DifferentialCommentPreviewController.php
+++ b/src/applications/differential/controller/commentpreview/DifferentialCommentPreviewController.php
@@ -16,7 +16,8 @@
 * limitations under the License.
 */

-class DifferentialCommentPreviewController extends DifferentialController {
+final class DifferentialCommentPreviewController
+  extends DifferentialController {

  private $id;

--- a/src/applications/differential/controller/commentsave/DifferentialCommentSaveController.php
+++ b/src/applications/differential/controller/commentsave/DifferentialCommentSaveController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class DifferentialCommentSaveController extends DifferentialController {
+final class DifferentialCommentSaveController extends DifferentialController {

  public function processRequest() {
    $request = $this->getRequest();
--- a/src/applications/differential/controller/diffcreate/DifferentialDiffCreateController.php
+++ b/src/applications/differential/controller/diffcreate/DifferentialDiffCreateController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class DifferentialDiffCreateController extends DifferentialController {
+final class DifferentialDiffCreateController extends DifferentialController {

  public function processRequest() {

--- a/src/applications/differential/controller/diffview/DifferentialDiffViewController.php
+++ b/src/applications/differential/controller/diffview/DifferentialDiffViewController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class DifferentialDiffViewController extends DifferentialController {
+final class DifferentialDiffViewController extends DifferentialController {

  private $id;

--- a/src/applications/differential/controller/inlinecommentedit/DifferentialInlineCommentEditController.php
+++ b/src/applications/differential/controller/inlinecommentedit/DifferentialInlineCommentEditController.php
@@ -16,7 +16,8 @@
 * limitations under the License.
 */

-class DifferentialInlineCommentEditController extends DifferentialController {
+final class DifferentialInlineCommentEditController
+  extends DifferentialController {

  private $revisionID;

--- a/src/applications/differential/controller/inlinecommentpreview/DifferentialInlineCommentPreviewController.php
+++ b/src/applications/differential/controller/inlinecommentpreview/DifferentialInlineCommentPreviewController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class DifferentialInlineCommentPreviewController
+final class DifferentialInlineCommentPreviewController
  extends DifferentialController {

  private $revisionID;
--- a/src/applications/differential/controller/revisionedit/DifferentialRevisionEditController.php
+++ b/src/applications/differential/controller/revisionedit/DifferentialRevisionEditController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class DifferentialRevisionEditController extends DifferentialController {
+final class DifferentialRevisionEditController extends DifferentialController {

  private $id;

--- a/src/applications/differential/controller/revisionlist/DifferentialRevisionListController.php
+++ b/src/applications/differential/controller/revisionlist/DifferentialRevisionListController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class DifferentialRevisionListController extends DifferentialController {
+final class DifferentialRevisionListController extends DifferentialController {

  private $filter;
  private $username;
--- a/src/applications/differential/controller/revisionstats/DifferentialRevisionStatsController.php
+++ b/src/applications/differential/controller/revisionstats/DifferentialRevisionStatsController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class DifferentialRevisionStatsController extends DifferentialController {
+final class DifferentialRevisionStatsController extends DifferentialController {
  private $filter;

  public function shouldRequireLogin() {
--- a/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php
+++ b/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class DifferentialRevisionViewController extends DifferentialController {
+final class DifferentialRevisionViewController extends DifferentialController {

  private $revisionID;

--- a/src/applications/differential/controller/subscribe/DifferentialSubscribeController.php
+++ b/src/applications/differential/controller/subscribe/DifferentialSubscribeController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class DifferentialSubscribeController extends DifferentialController {
+final class DifferentialSubscribeController extends DifferentialController {

  private $id;
  private $action;
--- a/src/applications/diffusion/controller/browse/DiffusionBrowseController.php
+++ b/src/applications/diffusion/controller/browse/DiffusionBrowseController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class DiffusionBrowseController extends DiffusionController {
+final class DiffusionBrowseController extends DiffusionController {

  public function processRequest() {
    $drequest = $this->diffusionRequest;
--- a/src/applications/diffusion/controller/change/DiffusionChangeController.php
+++ b/src/applications/diffusion/controller/change/DiffusionChangeController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class DiffusionChangeController extends DiffusionController {
+final class DiffusionChangeController extends DiffusionController {

  public function processRequest() {
    $drequest = $this->diffusionRequest;
--- a/src/applications/diffusion/controller/commit/DiffusionCommitController.php
+++ b/src/applications/diffusion/controller/commit/DiffusionCommitController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class DiffusionCommitController extends DiffusionController {
+final class DiffusionCommitController extends DiffusionController {

  const CHANGES_LIMIT = 100;

--- a/src/applications/diffusion/controller/diff/DiffusionDiffController.php
+++ b/src/applications/diffusion/controller/diff/DiffusionDiffController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class DiffusionDiffController extends DiffusionController {
+final class DiffusionDiffController extends DiffusionController {

  public function willProcessRequest(array $data) {
    $request = $this->getRequest();
--- a/src/applications/diffusion/controller/file/DiffusionBrowseFileController.php
+++ b/src/applications/diffusion/controller/file/DiffusionBrowseFileController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class DiffusionBrowseFileController extends DiffusionController {
+final class DiffusionBrowseFileController extends DiffusionController {

  // Image types we want to display inline using <img> tags
  protected $imageTypes = array(
--- a/src/applications/diffusion/controller/history/DiffusionHistoryController.php
+++ b/src/applications/diffusion/controller/history/DiffusionHistoryController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class DiffusionHistoryController extends DiffusionController {
+final class DiffusionHistoryController extends DiffusionController {

  public function processRequest() {
    $drequest = $this->diffusionRequest;
--- a/src/applications/diffusion/controller/home/DiffusionHomeController.php
+++ b/src/applications/diffusion/controller/home/DiffusionHomeController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class DiffusionHomeController extends DiffusionController {
+final class DiffusionHomeController extends DiffusionController {

  public function processRequest() {
    $request = $this->getRequest();
--- a/src/applications/diffusion/controller/lastmodified/DiffusionLastModifiedController.php
+++ b/src/applications/diffusion/controller/lastmodified/DiffusionLastModifiedController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class DiffusionLastModifiedController extends DiffusionController {
+final class DiffusionLastModifiedController extends DiffusionController {

  public function processRequest() {
    $drequest = $this->getDiffusionRequest();
--- a/src/applications/diffusion/controller/pathcomplete/DiffusionPathCompleteController.php
+++ b/src/applications/diffusion/controller/pathcomplete/DiffusionPathCompleteController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class DiffusionPathCompleteController extends DiffusionController {
+final class DiffusionPathCompleteController extends DiffusionController {

  public function willProcessRequest(array $data) {
    // Don't build a DiffusionRequest.
--- a/src/applications/diffusion/controller/pathvalidate/DiffusionPathValidateController.php
+++ b/src/applications/diffusion/controller/pathvalidate/DiffusionPathValidateController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class DiffusionPathValidateController extends DiffusionController {
+final class DiffusionPathValidateController extends DiffusionController {

  public function willProcessRequest(array $data) {
    // Don't build a DiffusionRequest.
--- a/src/applications/diffusion/controller/repository/DiffusionRepositoryController.php
+++ b/src/applications/diffusion/controller/repository/DiffusionRepositoryController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class DiffusionRepositoryController extends DiffusionController {
+final class DiffusionRepositoryController extends DiffusionController {

  public function processRequest() {
    $drequest = $this->diffusionRequest;
--- a/src/applications/diffusion/controller/symbol/DiffusionSymbolController.php
+++ b/src/applications/diffusion/controller/symbol/DiffusionSymbolController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class DiffusionSymbolController extends DiffusionController {
+final class DiffusionSymbolController extends DiffusionController {

  private $name;

--- a/src/applications/directory/controller/categorydelete/PhabricatorDirectoryCategoryDeleteController.php
+++ b/src/applications/directory/controller/categorydelete/PhabricatorDirectoryCategoryDeleteController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorDirectoryCategoryDeleteController
+final class PhabricatorDirectoryCategoryDeleteController
  extends PhabricatorDirectoryController {

  public function willProcessRequest(array $data) {
--- a/src/applications/directory/controller/categoryedit/PhabricatorDirectoryCategoryEditController.php
+++ b/src/applications/directory/controller/categoryedit/PhabricatorDirectoryCategoryEditController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorDirectoryCategoryEditController
+final class PhabricatorDirectoryCategoryEditController
  extends PhabricatorDirectoryController {

  private $id;
--- a/src/applications/directory/controller/itemdelete/PhabricatorDirectoryItemDeleteController.php
+++ b/src/applications/directory/controller/itemdelete/PhabricatorDirectoryItemDeleteController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorDirectoryItemDeleteController
+final class PhabricatorDirectoryItemDeleteController
  extends PhabricatorDirectoryController {

  public function willProcessRequest(array $data) {
--- a/src/applications/directory/controller/itemedit/PhabricatorDirectoryItemEditController.php
+++ b/src/applications/directory/controller/itemedit/PhabricatorDirectoryItemEditController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorDirectoryItemEditController
+final class PhabricatorDirectoryItemEditController
  extends PhabricatorDirectoryController {

  private $id;
--- a/src/applications/directory/controller/main/PhabricatorDirectoryMainController.php
+++ b/src/applications/directory/controller/main/PhabricatorDirectoryMainController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorDirectoryMainController
+final class PhabricatorDirectoryMainController
  extends PhabricatorDirectoryController {

  private $filter;
--- a/src/applications/files/controller/delete/PhabricatorFileDeleteController.php
+++ b/src/applications/files/controller/delete/PhabricatorFileDeleteController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorFileDeleteController extends PhabricatorFileController {
+final class PhabricatorFileDeleteController extends PhabricatorFileController {

  private $id;

--- a/src/applications/files/controller/dropupload/PhabricatorFileDropUploadController.php
+++ b/src/applications/files/controller/dropupload/PhabricatorFileDropUploadController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,8 @@
 * limitations under the License.
 */

-class PhabricatorFileDropUploadController extends PhabricatorFileController {
+final class PhabricatorFileDropUploadController
+  extends PhabricatorFileController {

  public function processRequest() {
    $request = $this->getRequest();
--- a/src/applications/files/controller/list/PhabricatorFileListController.php
+++ b/src/applications/files/controller/list/PhabricatorFileListController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorFileListController extends PhabricatorFileController {
+final class PhabricatorFileListController extends PhabricatorFileController {
  private $filter;

  private $showUploader;
--- a/src/applications/files/controller/macrodelete/PhabricatorFileMacroDeleteController.php
+++ b/src/applications/files/controller/macrodelete/PhabricatorFileMacroDeleteController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,8 @@
 * limitations under the License.
 */

-class PhabricatorFileMacroDeleteController extends PhabricatorFileController {
+final class PhabricatorFileMacroDeleteController
+  extends PhabricatorFileController {

  private $id;

--- a/src/applications/files/controller/macroedit/PhabricatorFileMacroEditController.php
+++ b/src/applications/files/controller/macroedit/PhabricatorFileMacroEditController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,8 @@
 * limitations under the License.
 */

-class PhabricatorFileMacroEditController extends PhabricatorFileController {
+final class PhabricatorFileMacroEditController
+  extends PhabricatorFileController {

  private $id;

--- a/src/applications/files/controller/macrolist/PhabricatorFileMacroListController.php
+++ b/src/applications/files/controller/macrolist/PhabricatorFileMacroListController.php
@@ -16,7 +16,9 @@
 * limitations under the License.
 */

-class PhabricatorFileMacroListController extends PhabricatorFileController {
+final class PhabricatorFileMacroListController
+  extends PhabricatorFileController {
+
  public function processRequest() {

    $request = $this->getRequest();
--- a/src/applications/files/controller/proxy/PhabricatorFileProxyController.php
+++ b/src/applications/files/controller/proxy/PhabricatorFileProxyController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorFileProxyController extends PhabricatorFileController {
+final class PhabricatorFileProxyController extends PhabricatorFileController {

  private $uri;

--- a/src/applications/files/controller/transform/PhabricatorFileTransformController.php
+++ b/src/applications/files/controller/transform/PhabricatorFileTransformController.php
@@ -16,7 +16,8 @@
 * limitations under the License.
 */

-class PhabricatorFileTransformController extends PhabricatorFileController {
+final class PhabricatorFileTransformController
+  extends PhabricatorFileController {

  private $transform;
  private $phid;
--- a/src/applications/files/controller/upload/PhabricatorFileUploadController.php
+++ b/src/applications/files/controller/upload/PhabricatorFileUploadController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorFileUploadController extends PhabricatorFileController {
+final class PhabricatorFileUploadController extends PhabricatorFileController {

  public function processRequest() {

--- a/src/applications/help/controller/keyboardshortcut/PhabricatorHelpKeyboardShortcutController.php
+++ b/src/applications/help/controller/keyboardshortcut/PhabricatorHelpKeyboardShortcutController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorHelpKeyboardShortcutController
+final class PhabricatorHelpKeyboardShortcutController
  extends PhabricatorHelpController {

  public function processRequest() {
--- a/src/applications/herald/controller/all/HeraldAllRulesController.php
+++ b/src/applications/herald/controller/all/HeraldAllRulesController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldAllRulesController extends HeraldController {
+final class HeraldAllRulesController extends HeraldController {

  private $view;
  private $viewPHID;
--- a/src/applications/herald/controller/delete/HeraldDeleteController.php
+++ b/src/applications/herald/controller/delete/HeraldDeleteController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldDeleteController extends HeraldController {
+final class HeraldDeleteController extends HeraldController {

  private $id;

--- a/src/applications/herald/controller/edithistory/HeraldRuleEditHistoryController.php
+++ b/src/applications/herald/controller/edithistory/HeraldRuleEditHistoryController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldRuleEditHistoryController extends HeraldController {
+final class HeraldRuleEditHistoryController extends HeraldController {

  private $id;

--- a/src/applications/herald/controller/home/HeraldHomeController.php
+++ b/src/applications/herald/controller/home/HeraldHomeController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldHomeController extends HeraldController {
+final class HeraldHomeController extends HeraldController {

  private $view;
  private $filter;
--- a/src/applications/herald/controller/new/HeraldNewController.php
+++ b/src/applications/herald/controller/new/HeraldNewController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldNewController extends HeraldController {
+final class HeraldNewController extends HeraldController {

  private $contentType;

--- a/src/applications/herald/controller/rule/HeraldRuleController.php
+++ b/src/applications/herald/controller/rule/HeraldRuleController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldRuleController extends HeraldController {
+final class HeraldRuleController extends HeraldController {

  private $id;
  private $filter;
--- a/src/applications/herald/controller/test/HeraldTestConsoleController.php
+++ b/src/applications/herald/controller/test/HeraldTestConsoleController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldTestConsoleController extends HeraldController {
+final class HeraldTestConsoleController extends HeraldController {

  public function getFilter() {
    return 'test';
--- a/src/applications/herald/controller/transcript/HeraldTranscriptController.php
+++ b/src/applications/herald/controller/transcript/HeraldTranscriptController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldTranscriptController extends HeraldController {
+final class HeraldTranscriptController extends HeraldController {

  const FILTER_AFFECTED = 'affected';
  const FILTER_OWNED    = 'owned';
--- a/src/applications/herald/controller/transcriptlist/HeraldTranscriptListController.php
+++ b/src/applications/herald/controller/transcriptlist/HeraldTranscriptListController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldTranscriptListController extends HeraldController {
+final class HeraldTranscriptListController extends HeraldController {

  public function getFilter() {
    return 'transcript';
--- a/src/applications/maniphest/controller/descriptionchange/ManiphestTaskDescriptionChangeController.php
+++ b/src/applications/maniphest/controller/descriptionchange/ManiphestTaskDescriptionChangeController.php
@@ -19,7 +19,8 @@
 /**
 * @group maniphest
 */
-class ManiphestTaskDescriptionChangeController extends ManiphestController {
+final class ManiphestTaskDescriptionChangeController
+  extends ManiphestController {

  private $transactionID;

@@ -33,13 +34,17 @@ class ManiphestTaskDescriptionChangeController extends ManiphestController {
  }

  public function willProcessRequest(array $data) {
-    $this->setTransactionID($data['id']);
+    $this->setTransactionID(idx($data, 'id'));
  }

  public function processRequest() {
    $request = $this->getRequest();
    $user = $request->getUser();

+    if (!$this->getTransactionID()) {
+      $this->setTransactionID($this->getRequest()->getStr('ref'));
+    }
+
    $transaction_id = $this->getTransactionID();
    $transaction = id(new ManiphestTransaction())->load($transaction_id);
    if (!$transaction) {
--- a/src/applications/maniphest/controller/descriptiondiff/ManiphestTaskDescriptionDiffController.php
+++ b/src/applications/maniphest/controller/descriptiondiff/ManiphestTaskDescriptionDiffController.php
@@ -1,29 +0,0 @@
-<?php
-
-/*
- * Copyright 2012 Facebook, Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-/**
- * @group maniphest
- */
-final class ManiphestTaskDescriptionDiffController
-  extends ManiphestTaskDescriptionChangeController {
-
-  public function willProcessRequest(array $data) {
-    $ref = $this->getRequest()->getStr('ref');
-    $this->setTransactionID($ref);
-  }
-}
--- a/src/applications/maniphest/controller/descriptiondiff/init.php
+++ b/src/applications/maniphest/controller/descriptiondiff/init.php
@@ -1,12 +0,0 @@
-<?php
-/**
- * This file is automatically generated. Lint this module to rebuild it.
- * @generated
- */
-
-
-
-phutil_require_module('phabricator', 'applications/maniphest/controller/descriptionchange');
-
-
-phutil_require_source('ManiphestTaskDescriptionDiffController.php');
--- a/src/applications/maniphest/controller/descriptionpreview/ManiphestTaskDescriptionPreviewController.php
+++ b/src/applications/maniphest/controller/descriptionpreview/ManiphestTaskDescriptionPreviewController.php
@@ -19,7 +19,8 @@
 /**
 * @group maniphest
 */
-class ManiphestTaskDescriptionPreviewController extends ManiphestController {
+final class ManiphestTaskDescriptionPreviewController
+  extends ManiphestController {

  public function processRequest() {

--- a/src/applications/maniphest/controller/taskdetail/ManiphestTaskDetailController.php
+++ b/src/applications/maniphest/controller/taskdetail/ManiphestTaskDetailController.php
@@ -19,7 +19,7 @@
 /**
 * @group maniphest
 */
-class ManiphestTaskDetailController extends ManiphestController {
+final class ManiphestTaskDetailController extends ManiphestController {

  private $id;

--- a/src/applications/maniphest/controller/taskedit/ManiphestTaskEditController.php
+++ b/src/applications/maniphest/controller/taskedit/ManiphestTaskEditController.php
@@ -19,7 +19,7 @@
 /**
 * @group maniphest
 */
-class ManiphestTaskEditController extends ManiphestController {
+final class ManiphestTaskEditController extends ManiphestController {

  private $id;

--- a/src/applications/maniphest/controller/tasklist/ManiphestTaskListController.php
+++ b/src/applications/maniphest/controller/tasklist/ManiphestTaskListController.php
@@ -19,7 +19,7 @@
 /**
 * @group maniphest
 */
-class ManiphestTaskListController extends ManiphestController {
+final class ManiphestTaskListController extends ManiphestController {

  const DEFAULT_PAGE_SIZE = 1000;

--- a/src/applications/maniphest/controller/transactionpreview/ManiphestTransactionPreviewController.php
+++ b/src/applications/maniphest/controller/transactionpreview/ManiphestTransactionPreviewController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -19,7 +19,7 @@
 /**
 * @group maniphest
 */
-class ManiphestTransactionPreviewController extends ManiphestController {
+final class ManiphestTransactionPreviewController extends ManiphestController {

  private $id;

--- a/src/applications/maniphest/controller/transactionsave/ManiphestTransactionSaveController.php
+++ b/src/applications/maniphest/controller/transactionsave/ManiphestTransactionSaveController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -19,7 +19,7 @@
 /**
 * @group maniphest
 */
-class ManiphestTransactionSaveController extends ManiphestController {
+final class ManiphestTransactionSaveController extends ManiphestController {

  public function processRequest() {
    $request = $this->getRequest();
--- a/src/applications/maniphest/view/transactionlist/ManiphestTransactionListView.php
+++ b/src/applications/maniphest/view/transactionlist/ManiphestTransactionListView.php
@@ -96,7 +96,7 @@ class ManiphestTransactionListView extends ManiphestView {
      require_celerity_resource('syntax-highlighting-css');
      $whitespace_mode = DifferentialChangesetParser::WHITESPACE_SHOW_ALL;
      Javelin::initBehavior('differential-show-more', array(
-        'uri'         => '/maniphest/task/descriptiondiff/',
+        'uri'         => '/maniphest/task/descriptionchange/',
        'whitespace'  => $whitespace_mode,
      ));
    }
--- a/src/applications/metamta/controller/list/PhabricatorMetaMTAListController.php
+++ b/src/applications/metamta/controller/list/PhabricatorMetaMTAListController.php
@@ -16,7 +16,8 @@
 * limitations under the License.
 */

-class PhabricatorMetaMTAListController extends PhabricatorMetaMTAController {
+final class PhabricatorMetaMTAListController
+  extends PhabricatorMetaMTAController {

  public function processRequest() {
    // Get a page of mails together with pager.
--- a/src/applications/metamta/controller/mailinglistedit/PhabricatorMetaMTAMailingListEditController.php
+++ b/src/applications/metamta/controller/mailinglistedit/PhabricatorMetaMTAMailingListEditController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorMetaMTAMailingListEditController
+final class PhabricatorMetaMTAMailingListEditController
  extends PhabricatorMetaMTAController {

  private $id;
--- a/src/applications/metamta/controller/mailinglists/PhabricatorMetaMTAMailingListsController.php
+++ b/src/applications/metamta/controller/mailinglists/PhabricatorMetaMTAMailingListsController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorMetaMTAMailingListsController
+final class PhabricatorMetaMTAMailingListsController
  extends PhabricatorMetaMTAController {

  public function processRequest() {
--- a/src/applications/metamta/controller/receive/PhabricatorMetaMTAReceiveController.php
+++ b/src/applications/metamta/controller/receive/PhabricatorMetaMTAReceiveController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorMetaMTAReceiveController
+final class PhabricatorMetaMTAReceiveController
  extends PhabricatorMetaMTAController {

  public function processRequest() {
--- a/src/applications/metamta/controller/receivedlist/PhabricatorMetaMTAReceivedListController.php
+++ b/src/applications/metamta/controller/receivedlist/PhabricatorMetaMTAReceivedListController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorMetaMTAReceivedListController
+final class PhabricatorMetaMTAReceivedListController
  extends PhabricatorMetaMTAController {

  public function processRequest() {
--- a/src/applications/metamta/controller/send/PhabricatorMetaMTASendController.php
+++ b/src/applications/metamta/controller/send/PhabricatorMetaMTASendController.php
@@ -16,7 +16,8 @@
 * limitations under the License.
 */

-class PhabricatorMetaMTASendController extends PhabricatorMetaMTAController {
+final class PhabricatorMetaMTASendController
+  extends PhabricatorMetaMTAController {

  public function processRequest() {

--- a/src/applications/metamta/controller/sendgridreceive/PhabricatorMetaMTASendGridReceiveController.php
+++ b/src/applications/metamta/controller/sendgridreceive/PhabricatorMetaMTASendGridReceiveController.php
@@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorMetaMTASendGridReceiveController
+final class PhabricatorMetaMTASendGridReceiveController
  extends PhabricatorMetaMTAController {

  public function shouldRequireLogin() {
--- a/src/applications/metamta/controller/view/PhabricatorMetaMTAViewController.php
+++ b/src/applications/metamta/controller/view/PhabricatorMetaMTAViewController.php
@@ -16,7 +16,8 @@
 * limitations under the License.
 */

-class PhabricatorMetaMTAViewController extends PhabricatorMetaMTAController {
+final class PhabricatorMetaMTAViewController
+  extends PhabricatorMetaMTAController {

  private $id;

--- a/src/applications/owners/controller/delete/PhabricatorOwnersDeleteController.php
+++ b/src/applications/owners/controller/delete/PhabricatorOwnersDeleteController.php
@@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -16,7 +16,8 @@
 * limitations under the License.
 */

-class PhabricatorOwnersDeleteController extends PhabricatorOwnersController {
+final class PhabricatorOwnersDeleteController
+  extends PhabricatorOwnersController {

  private $id;

--- a/Show More
+++ b/Show More