archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Replace Sprite-Icons with FontAwesome

Browse Source 
Summary: The removes the sprite sheet 'icons' and replaces it with FontAwesome fonts.

Test Plan:
- Grep for SPRITE_ICONS and replace
- Grep for sprite-icons and replace
- Grep for PhabricatorActionList and choose all new icons
- Grep for Crumbs and fix icons
- Test/Replace PHUIList Icon support
- Test/Replace ObjectList Icon support (foot, epoch, etc)
- Browse as many pages as I could get to
- Remove sprite-icons and move remarkup to own sheet
- Review this diff in Differential

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin, hach-que

Differential Revision: https://secure.phabricator.com/D9052
This commit is contained in:
Chad Little
2014-05-12 10:08:32 -07:00
parent dfcccd4cb8
commit b2f3001ec4
304 changed files with 635 additions and 3689 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/applications/diffusion/controller/DiffusionBrowseController.php
View File

@@ -94,7 +94,7 @@ abstract class DiffusionBrowseController extends DiffusionController {
id(new PhabricatorActionView())
->setName(pht('View History'))
->setHref($history_uri)
->setIcon('history'));
->setIcon('fa-list'));
$behind_head = $drequest->getRawCommit();
$head_uri = $drequest->generateURI(
@@ -106,7 +106,7 @@ abstract class DiffusionBrowseController extends DiffusionController {
id(new PhabricatorActionView())
->setName(pht('Jump to HEAD'))
->setHref($head_uri)
->setIcon('home')
->setIcon('fa-home')
->setDisabled(!$behind_head));
// TODO: Ideally, this should live in Owners and be event-triggered, but
@@ -125,7 +125,7 @@ abstract class DiffusionBrowseController extends DiffusionController {
id(new PhabricatorActionView())
->setName(pht('Find Owners'))
->setHref((string)$owners_uri)
->setIcon('preview'));
->setIcon('fa-users'));
}
return $view;

22
src/applications/diffusion/controller/DiffusionBrowseFileController.php
View File

@@ -334,15 +334,15 @@ final class DiffusionBrowseFileController extends DiffusionBrowseController {
array(
'action' => 'change',
)))
->setIcon('new'));
->setIcon('fa-backward'));
if ($show_blame) {
$blame_text = pht('Disable Blame');
$blame_icon = 'blame-grey';
$blame_icon = 'fa-exclamation-circle lightgreytext';
$blame_value = 0;
} else {
$blame_text = pht('Enable Blame');
$blame_icon = 'blame';
$blame_icon = 'fa-exclamation-circle';
$blame_value = 1;
}
@@ -356,11 +356,11 @@ final class DiffusionBrowseFileController extends DiffusionBrowseController {
if ($show_color) {
$highlight_text = pht('Disable Highlighting');
$highlight_icon = 'highlight-grey';
$highlight_icon = 'fa-star-o grey';
$highlight_value = 0;
} else {
$highlight_text = pht('Enable Highlighting');
$highlight_icon = 'highlight';
$highlight_icon = 'fa-star';
$highlight_value = 1;
}
@@ -393,7 +393,7 @@ final class DiffusionBrowseFileController extends DiffusionBrowseController {
id(new PhabricatorActionView())
->setName($lint_text)
->setHref($href)
->setIcon('warning')
->setIcon('fa-exclamation-triangle')
->setDisabled(!$href));
return $view;
@@ -413,8 +413,7 @@ final class DiffusionBrowseFileController extends DiffusionBrowseController {
$editor_link = $user->loadEditorLink($path, $line, $callsign);
$icon_edit = id(new PHUIIconView())
->setSpriteSheet(PHUIIconView::SPRITE_ICONS)
->setSpriteIcon('edit');
->setIconFont('fa-pencil');
$button = id(new PHUIButtonView())
->setTag('a')
->setText(pht('Open in Editor'))
@@ -432,16 +431,15 @@ final class DiffusionBrowseFileController extends DiffusionBrowseController {
if ($file_uri) {
$text = pht('Download Raw File');
$href = $file_uri;
$icon = 'download';
$icon = 'fa-download';
} else {
$text = pht('View Raw File');
$href = $base_uri->alter('view', 'raw');
$icon = 'file';
$icon = 'fa-file-text';
}
$iconview = id(new PHUIIconView())
->setSpriteSheet(PHUIIconView::SPRITE_ICONS)
->setSpriteIcon($icon);
->setIconFont($icon);
$button = id(new PHUIButtonView())
->setTag('a')
->setText($text)

9
src/applications/diffusion/controller/DiffusionCommitController.php
View File

@@ -252,8 +252,7 @@ final class DiffusionCommitController extends DiffusionController {
if ($count > self::CHANGES_LIMIT && !$show_all_details) {
$icon = id(new PHUIIconView())
->setSpriteSheet(PHUIIconView::SPRITE_ICONS)
->setSpriteIcon('transcript');
->setIconFont('fa-files-o');
$button = id(new PHUIButtonView())
->setText(pht('Show All Changes'))
@@ -987,7 +986,7 @@ final class DiffusionCommitController extends DiffusionController {
$action = id(new PhabricatorActionView())
->setName(pht('Edit Commit'))
->setHref($uri)
->setIcon('edit')
->setIcon('fa-pencil')
->setDisabled(!$can_edit)
->setWorkflow(!$can_edit);
$actions->addAction($action);
@@ -999,7 +998,7 @@ final class DiffusionCommitController extends DiffusionController {
if (PhabricatorApplication::isClassInstalled($maniphest)) {
$action = id(new PhabricatorActionView())
->setName(pht('Edit Maniphest Tasks'))
->setIcon('attach')
->setIcon('fa-anchor')
->setHref('/search/attach/'.$commit->getPHID().'/TASK/edge/')
->setWorkflow(true)
->setDisabled(!$can_edit);
@@ -1009,7 +1008,7 @@ final class DiffusionCommitController extends DiffusionController {
$action = id(new PhabricatorActionView())
->setName(pht('Download Raw Diff'))
->setHref($request->getRequestURI()->alter('diff', true))
->setIcon('download');
->setIcon('fa-download');
$actions->addAction($action);
return $actions;

16
src/applications/diffusion/controller/DiffusionRepositoryController.php
View File

@@ -287,8 +287,7 @@ final class DiffusionRepositoryController extends DiffusionController {
}
$icon = id(new PHUIIconView())
->setSpriteSheet(PHUIIconView::SPRITE_ICONS)
->setSpriteIcon('fork');
->setIconFont('fa-fork');
$button = new PHUIButtonView();
$button->setText(pht("Show All Branches"));
@@ -360,8 +359,7 @@ final class DiffusionRepositoryController extends DiffusionController {
}
$icon = id(new PHUIIconView())
->setSpriteSheet(PHUIIconView::SPRITE_ICONS)
->setSpriteIcon('tag');
->setIconFont('fa-tag');
$button = new PHUIButtonView();
$button->setText(pht("Show All Tags"));
@@ -399,7 +397,7 @@ final class DiffusionRepositoryController extends DiffusionController {
$view->addAction(
id(new PhabricatorActionView())
->setName(pht('Edit Repository'))
->setIcon('edit')
->setIcon('fa-pencil')
->setHref($edit_uri)
->setWorkflow(!$can_edit)
->setDisabled(!$can_edit));
@@ -412,7 +410,7 @@ final class DiffusionRepositoryController extends DiffusionController {
$view->addAction(
id(new PhabricatorActionView())
->setName(pht('View Push Logs'))
->setIcon('transcript')
->setIcon('fa-list-alt')
->setHref($push_uri));
}
@@ -461,8 +459,7 @@ final class DiffusionRepositoryController extends DiffusionController {
$callsign = $drequest->getRepository()->getCallsign();
$icon = id(new PHUIIconView())
->setSpriteSheet(PHUIIconView::SPRITE_ICONS)
->setSpriteIcon('transcript');
->setIconFont('fa-list-alt');
$button = id(new PHUIButtonView())
->setText(pht('View Full History'))
@@ -522,8 +519,7 @@ final class DiffusionRepositoryController extends DiffusionController {
->setHeader(pht('Repository'));
$icon = id(new PHUIIconView())
->setSpriteSheet(PHUIIconView::SPRITE_ICONS)
->setSpriteIcon('data');
->setIconFont('fa-folder-open');
$button = new PHUIButtonView();
$button->setText(pht('Browse Repository'));

32
src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
View File

@@ -203,7 +203,7 @@ final class DiffusionRepositoryEditMainController
->setUser($viewer);
$edit = id(new PhabricatorActionView())
->setIcon('edit')
->setIcon('fa-pencil')
->setName(pht('Edit Basic Information'))
->setHref($this->getRepositoryControllerURI($repository, 'edit/basic/'));
$view->addAction($edit);
@@ -215,11 +215,11 @@ final class DiffusionRepositoryEditMainController
if ($repository->isTracked()) {
$activate
->setIcon('disable')
->setIcon('fa-pause')
->setName(pht('Deactivate Repository'));
} else {
$activate
->setIcon('enable')
->setIcon('fa-play')
->setName(pht('Activate Repository'));
}
@@ -228,7 +228,7 @@ final class DiffusionRepositoryEditMainController
$view->addAction(
id(new PhabricatorActionView())
->setName(pht('Delete Repository'))
->setIcon('delete')
->setIcon('fa-times')
->setHref(
$this->getRepositoryControllerURI($repository, 'edit/delete/'))
->setDisabled(true)
@@ -304,7 +304,7 @@ final class DiffusionRepositoryEditMainController
->setUser($viewer);
$edit = id(new PhabricatorActionView())
->setIcon('edit')
->setIcon('fa-pencil')
->setName(pht('Edit Text Encoding'))
->setHref(
$this->getRepositoryControllerURI($repository, 'edit/encoding/'));
@@ -341,7 +341,7 @@ final class DiffusionRepositoryEditMainController
->setUser($viewer);
$edit = id(new PhabricatorActionView())
->setIcon('edit')
->setIcon('fa-pencil')
->setName(pht('Edit Policies'))
->setHref(
$this->getRepositoryControllerURI($repository, 'edit/policy/'));
@@ -388,7 +388,7 @@ final class DiffusionRepositoryEditMainController
->setUser($viewer);
$edit = id(new PhabricatorActionView())
->setIcon('edit')
->setIcon('fa-pencil')
->setName(pht('Edit Branches'))
->setHref(
$this->getRepositoryControllerURI($repository, 'edit/branches/'));
@@ -438,7 +438,7 @@ final class DiffusionRepositoryEditMainController
->setUser($viewer);
$edit = id(new PhabricatorActionView())
->setIcon('edit')
->setIcon('fa-pencil')
->setName(pht('Edit Subversion Info'))
->setHref(
$this->getRepositoryControllerURI($repository, 'edit/subversion/'));
@@ -478,7 +478,7 @@ final class DiffusionRepositoryEditMainController
->setUser($viewer);
$edit = id(new PhabricatorActionView())
->setIcon('edit')
->setIcon('fa-pencil')
->setName(pht('Edit Actions'))
->setHref(
$this->getRepositoryControllerURI($repository, 'edit/actions/'));
@@ -520,7 +520,7 @@ final class DiffusionRepositoryEditMainController
->setUser($viewer);
$edit = id(new PhabricatorActionView())
->setIcon('edit')
->setIcon('fa-pencil')
->setName(pht('Edit Remote'))
->setHref(
$this->getRepositoryControllerURI($repository, 'edit/remote/'));
@@ -562,7 +562,7 @@ final class DiffusionRepositoryEditMainController
->setUser($viewer);
$edit = id(new PhabricatorActionView())
->setIcon('edit')
->setIcon('fa-pencil')
->setName(pht('Edit Local'))
->setHref(
$this->getRepositoryControllerURI($repository, 'edit/local/'));
@@ -596,7 +596,7 @@ final class DiffusionRepositoryEditMainController
->setUser($user);
$edit = id(new PhabricatorActionView())
->setIcon('edit')
->setIcon('fa-pencil')
->setName(pht('Edit Hosting'))
->setHref(
$this->getRepositoryControllerURI($repository, 'edit/hosting/'));
@@ -605,14 +605,14 @@ final class DiffusionRepositoryEditMainController
if ($repository->canAllowDangerousChanges()) {
if ($repository->shouldAllowDangerousChanges()) {
$changes = id(new PhabricatorActionView())
->setIcon('blame')
->setIcon('fa-shield')
->setName(pht('Prevent Dangerous Changes'))
->setHref(
$this->getRepositoryControllerURI($repository, 'edit/dangerous/'))
->setWorkflow(true);
} else {
$changes = id(new PhabricatorActionView())
->setIcon('warning')
->setIcon('fa-bullseye')
->setName(pht('Allow Dangerous Changes'))
->setHref(
$this->getRepositoryControllerURI($repository, 'edit/dangerous/'))
@@ -1043,7 +1043,7 @@ final class DiffusionRepositoryEditMainController
$mirror_actions->addAction(
id(new PhabricatorActionView())
->setName(pht('Add Mirror'))
->setIcon('new')
->setIcon('fa-plus')
->setHref($new_mirror_uri)
->setWorkflow(true));
@@ -1092,7 +1092,7 @@ final class DiffusionRepositoryEditMainController
$item->addAction(
id(new PHUIListItemView())
->setIcon('edit')
->setIcon('fa-pencil')
->setHref($edit_uri)
->setWorkflow(true));

2
src/applications/diffusion/controller/DiffusionRepositoryListController.php
View File

@@ -48,7 +48,7 @@ final class DiffusionRepositoryListController extends DiffusionController {
->setName(pht('New Repository'))
->setHref($this->getApplicationURI('new/'))
->setDisabled(!$can_create)
->setIcon('create'));
->setIcon('fa-plus-square'));
return $crumbs;
}