Replace Sprite-Icons with FontAwesome

Summary: The removes the sprite sheet 'icons' and replaces it with FontAwesome fonts.

Test Plan:
- Grep for SPRITE_ICONS and replace
- Grep for sprite-icons and replace
- Grep for PhabricatorActionList and choose all new icons
- Grep for Crumbs and fix icons
- Test/Replace PHUIList Icon support
- Test/Replace ObjectList Icon support (foot, epoch, etc)
- Browse as many pages as I could get to
- Remove sprite-icons and move remarkup to own sheet
- Review this diff in Differential

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin, hach-que

Differential Revision: https://secure.phabricator.com/D9052
This commit is contained in:
Chad Little
2014-05-12 10:08:32 -07:00
parent dfcccd4cb8
commit b2f3001ec4
304 changed files with 635 additions and 3689 deletions

View File

@@ -38,7 +38,7 @@ abstract class ManiphestController extends PhabricatorController {
id(new PHUIListItemView())
->setName(pht('Create Task'))
->setHref($this->getApplicationURI('task/create/'))
->setIcon('create'));
->setIcon('fa-plus-square'));
return $crumbs;
}

View File

@@ -208,8 +208,7 @@ final class ManiphestTaskDetailController extends ManiphestController {
$submit_control = id(new PHUIFormMultiSubmitControl());
if (!$task->isClosed()) {
$close_image = id(new PHUIIconView())
->setSpriteSheet(PHUIIconView::SPRITE_ICONS)
->setSpriteIcon('check');
->setIconFont('fa-check-square-o');
$submit_control->addButtonView(
id(new PHUIButtonView())
->setColor(PHUIButtonView::GREY)
@@ -441,7 +440,7 @@ final class ManiphestTaskDetailController extends ManiphestController {
$view->addAction(
id(new PhabricatorActionView())
->setName(pht('Edit Task'))
->setIcon('edit')
->setIcon('fa-pencil')
->setHref($this->getApplicationURI("/task/edit/{$id}/"))
->setDisabled(!$can_edit)
->setWorkflow(!$can_edit));
@@ -451,11 +450,11 @@ final class ManiphestTaskDetailController extends ManiphestController {
id(new PhabricatorActionView())
->setName(pht('Automatically Subscribed'))
->setDisabled(true)
->setIcon('enable'));
->setIcon('fa-check-circle'));
} else {
$action = $viewer_is_cc ? 'rem' : 'add';
$name = $viewer_is_cc ? pht('Unsubscribe') : pht('Subscribe');
$icon = $viewer_is_cc ? 'disable' : 'check';
$icon = $viewer_is_cc ? 'fa-minus-circle' : 'fa-plus-circle';
$view->addAction(
id(new PhabricatorActionView())
@@ -471,7 +470,7 @@ final class ManiphestTaskDetailController extends ManiphestController {
->setName(pht('Merge Duplicates In'))
->setHref("/search/attach/{$phid}/TASK/merge/")
->setWorkflow(true)
->setIcon('merge')
->setIcon('fa-compress')
->setDisabled(!$can_edit)
->setWorkflow(true));
@@ -479,14 +478,14 @@ final class ManiphestTaskDetailController extends ManiphestController {
id(new PhabricatorActionView())
->setName(pht('Create Subtask'))
->setHref($this->getApplicationURI("/task/create/?parent={$id}"))
->setIcon('fork'));
->setIcon('fa-level-down'));
$view->addAction(
id(new PhabricatorActionView())
->setName(pht('Edit Dependencies'))
->setHref("/search/attach/{$phid}/TASK/dependencies/")
->setWorkflow(true)
->setIcon('link')
->setIcon('fa-link')
->setDisabled(!$can_edit)
->setWorkflow(true));