archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Minor, allow feed stories to publish with no related PHIDs (commits, future notifications).

Browse Source
This commit is contained in:
epriestley
2012-06-26 05:48:14 -07:00
parent 111ecabc5f
commit b3900a399c
1 changed files with 16 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/applications/feed/PhabricatorFeedStoryPublisher.php
View File

@@ -61,10 +61,6 @@ final class PhabricatorFeedStoryPublisher {
} }
public function publish() { public function publish() {
if (!$this->relatedPHIDs) {
throw new Exception("There are no PHIDs related to this story!");
}
if (!$this->storyType) { if (!$this->storyType) {
throw new Exception("Call setStoryType() before publishing!"); throw new Exception("Call setStoryType() before publishing!");
} }
@@ -78,6 +74,7 @@ final class PhabricatorFeedStoryPublisher {
$story->setChronologicalKey($chrono_key); $story->setChronologicalKey($chrono_key);
$story->save(); $story->save();
if ($this->relatedPHIDs) {
$ref = new PhabricatorFeedStoryReference(); $ref = new PhabricatorFeedStoryReference();
$sql = array(); $sql = array();
@@ -95,6 +92,7 @@ final class PhabricatorFeedStoryPublisher {
'INSERT INTO %T (objectPHID, chronologicalKey) VALUES %Q', 'INSERT INTO %T (objectPHID, chronologicalKey) VALUES %Q',
$ref->getTableName(), $ref->getTableName(),
implode(', ', $sql)); implode(', ', $sql));
}
if (PhabricatorEnv::getEnvConfig('notification.enabled')) { if (PhabricatorEnv::getEnvConfig('notification.enabled')) {
$this->insertNotifications($chrono_key); $this->insertNotifications($chrono_key);