Respect users with duplicate real names in commit parser
Test Plan:
$parser->resolveUserPHID('Lei Zhao');
$parser->resolveUserPHID('Jakub Vrana');
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D3437
This commit is contained in:
@@ -97,11 +97,11 @@ abstract class PhabricatorRepositoryCommitMessageDetailParser {
|
||||
private function findUserByRealName($real_name) {
|
||||
// Note, real names are not guaranteed unique, which is why we do it this
|
||||
// way.
|
||||
$by_realname = id(new PhabricatorUser())->loadOneWhere(
|
||||
'realName = %s LIMIT 1',
|
||||
$by_realname = id(new PhabricatorUser())->loadAllWhere(
|
||||
'realName = %s',
|
||||
$real_name);
|
||||
if ($by_realname) {
|
||||
return $by_realname->getPHID();
|
||||
if (count($by_realname) == 1) {
|
||||
return reset($by_realname)->getPHID();
|
||||
}
|
||||
return null;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user