Move "Change Username" from weird edit panel to standard object action

Summary: Ref T4065. Make this work in a more standard way which administrators have a reasonable shot at finding and using. See D8662 for discussion. Test Plan: Changed a user's username. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4065 Differential Revision: https://secure.phabricator.com/D8663
2014-04-02 12:05:19 -07:00
parent a6a19ac721
commit b53134bf32
6 changed files with 124 additions and 95 deletions
--- a/src/applications/people/controller/PhabricatorPeopleRenameController.php
+++ b/src/applications/people/controller/PhabricatorPeopleRenameController.php
@@ -0,0 +1,112 @@
+<?php
+
+final class PhabricatorPeopleRenameController
+  extends PhabricatorPeopleController {
+
+  private $id;
+
+  public function willProcessRequest(array $data) {
+    $this->id = $data['id'];
+  }
+
+  public function processRequest() {
+    $request = $this->getRequest();
+    $admin = $request->getUser();
+
+    $user = id(new PhabricatorPeopleQuery())
+      ->setViewer($admin)
+      ->withIDs(array($this->id))
+      ->executeOne();
+    if (!$user) {
+      return new Aphront404Response();
+    }
+
+    $profile_uri = '/p/'.$user->getUsername();
+
+    $errors = array();
+
+    $v_username = $user->getUsername();
+    $e_username = true;
+    if ($request->isFormPost()) {
+      $v_username = $request->getStr('username');
+
+
+      if (!strlen($v_username)) {
+        $e_username = pht('Required');
+        $errors[] = pht('New username is required.');
+      } else if ($v_username == $user->getUsername()) {
+        $e_username = pht('Invalid');
+        $errors[] = pht('New username must be different from old username.');
+      } else if (!PhabricatorUser::validateUsername($v_username)) {
+        $e_username = pht('Invalid');
+        $errors[] = PhabricatorUser::describeValidUsername();
+      }
+
+      if (!$errors) {
+        try {
+          id(new PhabricatorUserEditor())
+            ->setActor($admin)
+            ->changeUsername($user, $v_username);
+
+          $new_uri = '/p/'.$v_username.'/';
+
+          return id(new AphrontRedirectResponse())->setURI($new_uri);
+        } catch (AphrontQueryDuplicateKeyException $ex) {
+          $e_username = pht('Not Unique');
+          $errors[] = pht('Another user already has that username.');
+        }
+      }
+    }
+
+    $inst1 = pht(
+      'Be careful when renaming users!');
+
+    $inst2 = pht(
+      'The old username will no longer be tied to the user, so anything '.
+      'which uses it (like old commit messages) will no longer associate '.
+      'correctly. (And, if you give a user a username which some other user '.
+      'used to have, username lookups will begin returning the wrong user.)');
+
+    $inst3 = pht(
+      'It is generally safe to rename newly created users (and test users '.
+      'and so on), but less safe to rename established users and unsafe to '.
+      'reissue a username.');
+
+    $inst4 = pht(
+      'Users who rely on password authentication will need to reset their '.
+      'password after their username is changed (their username is part of '.
+      'the salt in the password hash). They will receive an email with '.
+      'instructions on how to do this.');
+
+    $form = id(new AphrontFormView())
+      ->setUser($admin)
+      ->appendChild(
+        id(new AphrontFormStaticControl())
+          ->setLabel(pht('Old Username'))
+          ->setValue($user->getUsername()))
+      ->appendChild(
+        id(new AphrontFormTextControl())
+          ->setLabel(pht('New Username'))
+          ->setValue($v_username)
+          ->setName('username')
+          ->setError($e_username));
+
+    if ($errors) {
+      $errors = id(new AphrontErrorView())->setErrors($errors);
+    }
+
+    return $this->newDialog()
+      ->setWidth(AphrontDialogView::WIDTH_FORM)
+      ->setTitle(pht('Change Username'))
+      ->appendChild($errors)
+      ->appendParagraph($inst1)
+      ->appendParagraph($inst2)
+      ->appendParagraph($inst3)
+      ->appendParagraph($inst4)
+      ->appendParagraph(null)
+      ->appendChild($form->buildLayoutView())
+      ->addSubmitButton(pht('Rename User'))
+      ->addCancelButton($profile_uri);
+  }
+
+}