Use EditEngine stacked comments in Diffusion

Summary: Ref T10978. Ref T8739. Fixes T10446. Converts Diffusion to modern comment/preview code, like Differential.

Test Plan: {F2342933}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10978, T10446, T8739

Differential Revision: https://secure.phabricator.com/D17183

webroot/rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js

@@ -1,47 +0,0 @@
-/**
- * @provides javelin-behavior-differential-add-reviewers-and-ccs
- * @requires javelin-behavior
- *           javelin-dom
- *           phabricator-prefab
- */
-
-JX.behavior('differential-add-reviewers-and-ccs', function(config) {
-
-  var dynamic = {};
-  for (var k in config.dynamic) {
-    var props = config.dynamic[k];
-    props.id = k;
-
-    var tokenizer = JX.Prefab.buildTokenizer(props).tokenizer;
-    tokenizer.start();
-
-    dynamic[k] = {
-      row : JX.$(props.row),
-      tokenizer : tokenizer,
-      actions : props.actions,
-      labels: props.labels
-    };
-  }
-
-  JX.DOM.listen(
-    JX.$(config.select),
-    'change',
-    null,
-    function() {
-      var v = JX.$(config.select).value;
-      for (var k in dynamic) {
-        if (dynamic[k].actions[v]) {
-          JX.DOM.show(dynamic[k].row);
-          if (dynamic[k].labels) {
-            var label_node = JX.DOM.find(dynamic[k].row, 'label');
-            if (label_node) {
-              JX.DOM.setContent(label_node, dynamic[k].labels[v]);
-            }
-          }
-          dynamic[k].tokenizer.refresh();
-        } else {
-          JX.DOM.hide(dynamic[k].row);
-        }
-      }
-    });
-});

webroot/rsrc/js/application/differential/behavior-keyboard-nav.js

@@ -173,16 +173,6 @@ JX.behavior('differential-keyboard-navigation', function(config) {
       refreshFocus();
     });
 
-  var haunt_mode = 0;
-  function haunt() {
-    haunt_mode = (haunt_mode + 1) % 3;
-
-    var el = JX.$(config.haunt);
-    for (var ii = 1; ii <= 2; ii++) {
-      JX.DOM.alterClass(el, 'differential-haunt-mode-'+ii, (haunt_mode == ii));
-    }
-  }
-
   new JX.KeyboardShortcut('j', 'Jump to next change.')
     .setHandler(function(manager) {
       jump(manager, 1);
@@ -271,10 +261,4 @@ JX.behavior('differential-keyboard-navigation', function(config) {
     })
     .register();
 
-  if (config.haunt) {
-    new JX.KeyboardShortcut('z', 'Cycle comment panel haunting modes.')
-      .setHandler(haunt)
-      .register();
-  }
-
 });