Use EditEngine stacked comments in Diffusion
Summary: Ref T10978. Ref T8739. Fixes T10446. Converts Diffusion to modern comment/preview code, like Differential.
Test Plan: {F2342933}
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10978, T10446, T8739
Differential Revision: https://secure.phabricator.com/D17183
This commit is contained in:
@@ -173,16 +173,6 @@ JX.behavior('differential-keyboard-navigation', function(config) {
|
||||
refreshFocus();
|
||||
});
|
||||
|
||||
var haunt_mode = 0;
|
||||
function haunt() {
|
||||
haunt_mode = (haunt_mode + 1) % 3;
|
||||
|
||||
var el = JX.$(config.haunt);
|
||||
for (var ii = 1; ii <= 2; ii++) {
|
||||
JX.DOM.alterClass(el, 'differential-haunt-mode-'+ii, (haunt_mode == ii));
|
||||
}
|
||||
}
|
||||
|
||||
new JX.KeyboardShortcut('j', 'Jump to next change.')
|
||||
.setHandler(function(manager) {
|
||||
jump(manager, 1);
|
||||
@@ -271,10 +261,4 @@ JX.behavior('differential-keyboard-navigation', function(config) {
|
||||
})
|
||||
.register();
|
||||
|
||||
if (config.haunt) {
|
||||
new JX.KeyboardShortcut('z', 'Cycle comment panel haunting modes.')
|
||||
.setHandler(haunt)
|
||||
.register();
|
||||
}
|
||||
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user