archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Show logs to the console in 'phd debug'

Browse Source 
Summary:
Currently we send logs to the logfile in 'phd debug', but we should send them to
the console instead.

Also fixed some %C stuff which could theoretically cause problems if a user had
percentage symbols in their paths (heaven forbid).

fratrik, this or D535 might have been involved in frustrating your efforts to
debug the "sudo" stuff.

Test Plan:
Ran "phd debug irc derpderp" and "phd launch irc derpderp". In the former case,
the exception appeared in the console. In the latter, it appeared in the log.

Reviewed By: codeblock
Reviewers: codeblock, jungejason, tuomaspelkonen, aran, fratrik
CC: aran, codeblock
Differential Revision: 536
This commit is contained in:
epriestley
2011-06-26 20:14:11 -07:00
parent 451b0e07dc
commit b61e325f05
2 changed files with 27 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
scripts/daemon/phabricator_daemon_launcher.php
View File

@@ -163,7 +163,15 @@ switch (isset($argv[1]) ? $argv[1] : 'help') {
$daemon = reset($match);
}
will_launch($control);
$with_logs = true;
if ($is_debug) {
// In debug mode, we emit errors straight to stdout, so nothing useful
// will show up in the logs. Don't echo the message about stuff showing
// up in them, since it would be confusing.
$with_logs = false;
}
will_launch($control, $with_logs);
if ($is_debug) {
echo "Launching {$daemon} in debug mode (nondaemonized)...\n";
@@ -217,10 +225,12 @@ function phd_load_tracked_repositories() {
return $repositories;
}
function will_launch($control) {
function will_launch($control, $with_logs = true) {
echo "Staging launch...\n";
$control->pingConduit();
$log_dir = $control->getControlDirectory('log').'/daemons.log';
echo "NOTE: Logs will appear in '{$log_dir}'.\n\n";
if ($with_logs) {
$log_dir = $control->getControlDirectory('log').'/daemons.log';
echo "NOTE: Logs will appear in '{$log_dir}'.\n\n";
}
}