Kill PhabricatorObjectDataHandle

Summary: Ref T603. Killing this class is cool because the classes that replace it are policy-aware. Tried to keep my wits about me as I did this and fixed a few random things along the way. (Ones I remember right now are pulling a query outside of a foreach loop in Releeph and fixing the text in UIExample to note that the ace of hearts if "a powerful" card and not the "most powerful" card (Q of spades gets that honor IMO))

Test Plan: tested the first few changes (execute, executeOne X handle, object) then got real mechanical / careful with the other changes.

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, aran, FacebookPOC

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D6941
This commit is contained in:
Bob Trahan
2013-09-11 12:27:28 -07:00
parent 07b8becfc6
commit b902005bed
92 changed files with 336 additions and 364 deletions

View File

@@ -267,9 +267,10 @@ abstract class PhabricatorController extends AphrontController {
}
protected function loadViewerHandles(array $phids) {
return id(new PhabricatorObjectHandleData($phids))
return id(new PhabricatorHandleQuery())
->setViewer($this->getRequest()->getUser())
->loadHandles();
->withPHIDs($phids)
->execute();
}