archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix reuse of $link in report controller

Browse Source 
Summary: $link gets reused later in the function, use a different variable name to avoid broken nonsense.

Test Plan: Clicked users/projects links.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, epriestley

Maniphest Tasks: T1038

Differential Revision: https://secure.phabricator.com/D2003
This commit is contained in:
epriestley
2012-03-23 11:08:10 -07:00
parent e722aa3f80
commit b9931fa340
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/applications/maniphest/controller/report/ManiphestReportController.php
View File

@@ -433,7 +433,7 @@ final class ManiphestReportController extends ManiphestController {
'(Up For Grabs)'); '(Up For Grabs)');
$col_header = 'User'; $col_header = 'User';
$header = 'Open Tasks by User and Priority ('.$date.')'; $header = 'Open Tasks by User and Priority ('.$date.')';
$link = '/maniphest/?users='; $base_link = '/maniphest/?users=';
break; break;
case 'project': case 'project':
$result = array(); $result = array();
@@ -470,7 +470,7 @@ final class ManiphestReportController extends ManiphestController {
'(No Project)'); '(No Project)');
$col_header = 'Project'; $col_header = 'Project';
$header = 'Open Tasks by Project and Priority ('.$date.')'; $header = 'Open Tasks by Project and Priority ('.$date.')';
$link = '/maniphest/view/all/?projects='; $base_link = '/maniphest/view/all/?projects=';
break; break;
} }
@@ -498,7 +498,7 @@ final class ManiphestReportController extends ManiphestController {
$name = phutil_render_tag( $name = phutil_render_tag(
'a', 'a',
array( array(
'href' => $link.$handle->getPHID(), 'href' => $base_link.$handle->getPHID(),
), ),
phutil_escape_html($handle->getName())); phutil_escape_html($handle->getName()));
$closed = idx($result_closed, $handle->getPHID(), array()); $closed = idx($result_closed, $handle->getPHID(), array());