Fix an issue with PHID/handle management in push logs

Summary: Ref T10751. This cleans this up so it's a little more modern, and fixes a possible bad access on the log detail page.

Test Plan: Viewed push log list, viewed push log detail.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10751

Differential Revision: https://secure.phabricator.com/D15765
This commit is contained in:
epriestley
2016-04-19 20:25:21 -07:00
parent 48b015a3fa
commit b9cf9e6f0d
3 changed files with 16 additions and 25 deletions

View File

@@ -50,8 +50,7 @@ final class DiffusionPushEventViewController
$updates_table = id(new DiffusionPushLogListView())
->setUser($viewer)
->setLogs($logs)
->setHandles($this->loadViewerHandles(mpull($logs, 'getPusherPHID')));
->setLogs($logs);
$update_box = id(new PHUIObjectBoxView())
->setHeaderText(pht('All Pushed Updates'))