Move people box on project pages

Summary: This removes the people box and adds a members property list item it's place. We may want some show/hide/see all if a project has more than //n// members, but these seems more reasonable than previous layout.

Test Plan: Tested a project with and without members, grepped for removed CSS, and tested mobile and desktop layouts.

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D7870

src/applications/project/controller/PhabricatorProjectProfileController.php

@@ -45,16 +45,10 @@ final class PhabricatorProjectProfileController
     $query->setViewer($this->getRequest()->getUser());
     $stories = $query->execute();
     $feed = $this->renderStories($stories);
-    $people = $this->renderPeoplePage($project, $profile);
-
-    $content = id(new AphrontMultiColumnView())
-      ->addColumn($people)
-      ->addColumn($feed)
-      ->setFluidLayout(true);
 
     $content = phutil_tag_div(
       'phabricator-project-layout',
-      array($tasks, $content));
+      array($tasks, $feed));
 
     $header = id(new PHUIHeaderView())
       ->setHeader($project->getName())
@@ -92,37 +86,6 @@ final class PhabricatorProjectProfileController
       ));
   }
 
-  private function renderPeoplePage(
-    PhabricatorProject $project,
-    PhabricatorProjectProfile $profile) {
-
-    $member_phids = $project->getMemberPHIDs();
-    $handles = $this->loadViewerHandles($member_phids);
-
-    $affiliated = array();
-    foreach ($handles as $phids => $handle) {
-      $affiliated[] = phutil_tag('li', array(), $handle->renderLink());
-    }
-
-    if ($affiliated) {
-      $affiliated = phutil_tag('ul', array(), $affiliated);
-    } else {
-      $affiliated = phutil_tag('p', array(),
-        phutil_tag('em', array(),
-          pht('No one is affiliated with this project.')));
-    }
-
-    return phutil_tag_div(
-      'phabricator-profile-info-group profile-wrap-responsive',
-      array(
-        phutil_tag(
-          'h1',
-          array('class' => 'phabricator-profile-info-header'),
-          pht('People')),
-        phutil_tag_div('phabricator-profile-info-pane', $affiliated),
-      ));
-  }
-
   private function renderFeedPage(
     PhabricatorProject $project,
     PhabricatorProjectProfile $profile) {
@@ -149,7 +112,7 @@ final class PhabricatorProjectProfileController
     $view = $builder->buildView();
 
     return phutil_tag_div(
-      'profile-feed profile-wrap-responsive',
+      'profile-feed',
       $view->render());
   }
 
@@ -267,6 +230,8 @@ final class PhabricatorProjectProfileController
     $request = $this->getRequest();
     $viewer = $request->getUser();
 
+    $this->loadHandles($project->getMemberPHIDs());
+
     $view = id(new PHUIPropertyListView())
       ->setUser($viewer)
       ->setObject($project)
@@ -276,6 +241,12 @@ final class PhabricatorProjectProfileController
       pht('Created'),
       phabricator_datetime($project->getDateCreated(), $viewer));
 
+    $view->addProperty(
+      pht('Members'),
+      $project->getMemberPHIDs()
+      ? $this->renderHandlesForPHIDs($project->getMemberPHIDs(), ',')
+      : phutil_tag('em', array(), pht('None')));
+
     $view->addSectionHeader(pht('Description'));
     $view->addTextContent(
       PhabricatorMarkupEngine::renderOneObject(