Add an "Add CCs" action to Differential

Summary:
We currently have only an "Add reviewers" action, add "Add CCs". This can also
be accomplished less-discoverably with mentions.

Test Plan:
Added reviewers and CCs to revisions. Toggled display between reviewers and CCs.

Reviewed By: jungejason
Reviewers: tomo, mroch, jsp, jungejason, aran, tuomaspelkonen
CC: aran, jungejason
Differential Revision: 521
This commit is contained in:
epriestley
2011-06-24 12:21:48 -07:00
parent 4469ef8f30
commit bb4cf7d6b3
10 changed files with 147 additions and 49 deletions

View File

@@ -33,6 +33,7 @@ class DifferentialCommentSaveController extends DifferentialController {
$comment = $request->getStr('comment');
$action = $request->getStr('action');
$reviewers = $request->getArr('reviewers');
$ccs = $request->getArr('ccs');
$editor = new DifferentialCommentEditor(
$revision,
@@ -44,6 +45,7 @@ class DifferentialCommentSaveController extends DifferentialController {
->setAttachInlineComments(true)
->setAddCC($action != DifferentialAction::ACTION_RESIGN)
->setAddedReviewers($reviewers)
->setAddedCCs($ccs)
->save();
// TODO: Diff change detection?