archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fixed losing full size feed for maniphest task creation

Browse Source 
Summary: After D2571, feed for maniphest task creation was being generated non-full-size. Fixed this by properly getting the maniphest action from story data.

Test Plan: Feed seems to work fine and the feed for task creation is full-sized.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: allenjohnashton, ddfisher, aran, Korvin

Differential Revision: https://secure.phabricator.com/D2691
This commit is contained in:
Keebuhm Park
2012-06-08 14:30:53 -07:00
committed by epriestley
parent d90a6cfbd1
commit be0e16ff7d
1 changed files with 17 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/applications/feed/story/PhabricatorFeedStoryManiphest.php
View File

@@ -40,13 +40,11 @@ final class PhabricatorFeedStoryManiphest
$view = new PhabricatorFeedStoryView();
$line = $this->getLineForData($data);
$view->setTitle($line);
$view->setEpoch($data->getEpoch());
$action = $this->getLineForData($data);
$view->setTitle($action);
$view->setEpoch($data->getEpoch());
$action = $data->getValue('action');
switch ($action) {
case ManiphestAction::ACTION_CREATE:
$full_size = true;
@@ -57,7 +55,7 @@ final class PhabricatorFeedStoryManiphest
}
if ($full_size) {
$view->setImage($this->getHandle($this->getAuthorPHID())->getImageURI());
$view->setImage($this->getHandle($data->getAuthorPHID())->getImageURI());
$content = $this->renderSummary($data->getValue('description'));
$view->appendChild($content);
} else {
@@ -67,7 +65,6 @@ final class PhabricatorFeedStoryManiphest
return $view;
}
public function renderNotificationView() {
$data = $this->getStoryData();