Fix various app nav issues

Summary:
  - Fix width, corresponding to wider sprites.
  - Sprite the "Audit" icon.
  - Mark the meta-application as device-ready.
  - Fix some collapse/expand bugs with the draggable local navs.
  - Add texture to local nav.
  - Darken the application nav to make it more cohesive with the main nav. I think this is an improvement?

Test Plan: See screenshots.

Reviewers: chad, btrahan

Reviewed By: btrahan

CC: aran, netfoxcity

Maniphest Tasks: T1569

Differential Revision: https://secure.phabricator.com/D3338
This commit is contained in:
epriestley
2012-08-20 14:13:15 -07:00
parent 6ed202b675
commit bee112c575
11 changed files with 87 additions and 74 deletions

View File

@@ -65,8 +65,8 @@ celerity_register_resource_map(array(
),
'/rsrc/image/autosprite.png' =>
array(
'hash' => '08fb34fc4ce0cd3be882a3177423ad49',
'uri' => '/res/08fb34fc/rsrc/image/autosprite.png',
'hash' => '5df245706c30b098cc45a5dc05775a65',
'uri' => '/res/5df24570/rsrc/image/autosprite.png',
'disk' => '/rsrc/image/autosprite.png',
'type' => 'png',
),
@@ -126,6 +126,13 @@ celerity_register_resource_map(array(
'disk' => '/rsrc/image/divot.png',
'type' => 'png',
),
'/rsrc/image/glyphicons.png' =>
array(
'hash' => '564fc282dac06bf8bb839457adaa3718',
'uri' => '/res/564fc282/rsrc/image/glyphicons.png',
'disk' => '/rsrc/image/glyphicons.png',
'type' => 'png',
),
'/rsrc/image/grippy_texture.png' =>
array(
'hash' => 'a8945e12ceeaddd5b491a8d81cfa19c1',
@@ -448,6 +455,13 @@ celerity_register_resource_map(array(
'disk' => '/rsrc/image/logo_grey.png',
'type' => 'png',
),
'/rsrc/image/menu_texture.png' =>
array(
'hash' => '42193f24a52bd94be596c442d59a68ce',
'uri' => '/res/42193f24/rsrc/image/menu_texture.png',
'disk' => '/rsrc/image/menu_texture.png',
'type' => 'png',
),
'/rsrc/image/search.png' =>
array(
'hash' => 'ff7da044e6f923b8f569dec11f97e5e5',
@@ -643,7 +657,7 @@ celerity_register_resource_map(array(
),
'autosprite-css' =>
array(
'uri' => '/res/07043fce/rsrc/css/autosprite.css',
'uri' => '/res/27f100be/rsrc/css/autosprite.css',
'type' => 'css',
'requires' =>
array(
@@ -1468,7 +1482,7 @@ celerity_register_resource_map(array(
),
'javelin-behavior-phabricator-nav' =>
array(
'uri' => '/res/cb8979b2/rsrc/js/application/core/behavior-phabricator-nav.js',
'uri' => '/res/2217e1e9/rsrc/js/application/core/behavior-phabricator-nav.js',
'type' => 'js',
'requires' =>
array(
@@ -2417,7 +2431,7 @@ celerity_register_resource_map(array(
),
'phabricator-nav-view-css' =>
array(
'uri' => '/res/ca2744bd/rsrc/css/aphront/phabricator-nav-view.css',
'uri' => '/res/3ee38144/rsrc/css/aphront/phabricator-nav-view.css',
'type' => 'css',
'requires' =>
array(
@@ -2457,7 +2471,7 @@ celerity_register_resource_map(array(
),
'phabricator-object-item-list-view-css' =>
array(
'uri' => '/res/7a31c016/rsrc/css/layout/phabricator-object-item-list-view.css',
'uri' => '/res/945fabe9/rsrc/css/layout/phabricator-object-item-list-view.css',
'type' => 'css',
'requires' =>
array(

View File

@@ -26,8 +26,8 @@ final class PhabricatorApplicationAudit extends PhabricatorApplication {
return '/audit/';
}
public function getIconURI() {
return celerity_get_resource_uri('/rsrc/image/app/app_audit.png');
public function getAutospriteName() {
return 'audit';
}
public function getRoutes() {

View File

@@ -1,35 +0,0 @@
<?php
/*
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
abstract class PhabricatorApplicationsController extends PhabricatorController {
public function buildStandardPageResponse($view, array $data) {
$page = $this->buildStandardPageView();
$page->setApplicationName('Applications');
$page->setBaseURI('/applications/');
$page->setTitle(idx($data, 'title'));
$page->setGlyph("\xE0\xBC\x84");
$page->appendChild($view);
$response = new AphrontWebpageResponse();
return $response->setContent($page->render());
}
}

View File

@@ -56,6 +56,7 @@ final class PhabricatorApplicationsListController
$view,
array(
'title' => 'Applications',
'device' => true,
));
}