archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Move PHUIErrorView to PHUIInfoView

Browse Source 
Summary: Since this element isn't strictly about errors, re-label as info view instead.

Test Plan: Grepped for all callsites, tested UIExamples and a few other random pages.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: hach-que, Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11867
This commit is contained in:
Chad Little
2015-03-01 14:45:56 -08:00
parent 5b104e291a
commit c038c643f4
82 changed files with 263 additions and 257 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/applications/differential/controller/DifferentialDiffViewController.php
View File

@@ -29,8 +29,8 @@ final class DifferentialDiffViewController extends DifferentialController {
->setURI('/D'.$diff->getRevisionID().'?id='.$diff->getID());
}
$error_view = id(new PHUIErrorView())
->setSeverity(PHUIErrorView::SEVERITY_NOTICE);
$error_view = id(new PHUIInfoView())
->setSeverity(PHUIInfoView::SEVERITY_NOTICE);
// TODO: implement optgroup support in AphrontFormSelectControl?
$select = array();
$select[] = hsprintf('<optgroup label="%s">', pht('Create New Revision'));

2
src/applications/differential/controller/DifferentialRevisionLandController.php
View File

@@ -52,7 +52,7 @@ final class DifferentialRevisionLandController extends DifferentialController {
} else {
$text = phutil_tag('pre', array(), $ex->getMessage());
}
$text = id(new PHUIErrorView())
$text = id(new PHUIInfoView())
->appendChild($text);
}

12
src/applications/differential/controller/DifferentialRevisionViewController.php
View File

@@ -137,9 +137,9 @@ final class DifferentialRevisionViewController extends DifferentialController {
$large = $request->getStr('large');
if (count($changesets) > $limit && !$large) {
$count = count($changesets);
$warning = new PHUIErrorView();
$warning = new PHUIInfoView();
$warning->setTitle('Very Large Diff');
$warning->setSeverity(PHUIErrorView::SEVERITY_WARNING);
$warning->setSeverity(PHUIInfoView::SEVERITY_WARNING);
$warning->appendChild(hsprintf(
'%s <strong>%s</strong>',
pht(
@@ -258,8 +258,8 @@ final class DifferentialRevisionViewController extends DifferentialController {
$warning_handle_map,
$handles);
if ($revision_warnings) {
$revision_warnings = id(new PHUIErrorView())
->setSeverity(PHUIErrorView::SEVERITY_WARNING)
$revision_warnings = id(new PHUIInfoView())
->setSeverity(PHUIInfoView::SEVERITY_WARNING)
->setErrors($revision_warnings);
$revision_detail_box->setErrorView($revision_warnings);
}
@@ -386,8 +386,8 @@ final class DifferentialRevisionViewController extends DifferentialController {
$review_warnings = array_mergev($review_warnings);
if ($review_warnings) {
$review_warnings_panel = id(new PHUIErrorView())
->setSeverity(PHUIErrorView::SEVERITY_WARNING)
$review_warnings_panel = id(new PHUIInfoView())
->setSeverity(PHUIInfoView::SEVERITY_WARNING)
->setErrors($review_warnings);
$comment_form->setErrorView($review_warnings_panel);
}