Rename policy capabilities

Summary: Ref T5655. Rename `PhabricatorPolicyCapability` subclasses for consistency.

Test Plan: Browsed a few applications, nothing seemed broken.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin, hach-que

Maniphest Tasks: T5655

Differential Revision: https://secure.phabricator.com/D10037

src/applications/diffusion/controller/DiffusionRepositoryCreateController.php

@@ -38,7 +38,7 @@ final class DiffusionRepositoryCreateController
       case 'import':
       case 'create':
         $this->requireApplicationCapability(
-          DiffusionCapabilityCreateRepositories::CAPABILITY);
+          DiffusionCreateRepositoriesCapability::CAPABILITY);
 
         $cancel_uri = $this->getApplicationURI('new/');
         break;
@@ -671,7 +671,7 @@ final class DiffusionRepositoryCreateController
 
     $push_policy = id(new AphrontFormPolicyControl())
       ->setUser($viewer)
-      ->setCapability(DiffusionCapabilityPush::CAPABILITY)
+      ->setCapability(DiffusionPushCapability::CAPABILITY)
       ->setPolicyObject($repository)
       ->setPolicies($policies)
       ->setName('pushPolicy');
@@ -849,5 +849,4 @@ final class DiffusionRepositoryCreateController
     return $this->repository;
   }
 
-
 }

src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php

@@ -372,7 +372,7 @@ final class DiffusionRepositoryEditMainController
       $descriptions[PhabricatorPolicyCapability::CAN_EDIT]);
 
     $pushable = $repository->isHosted()
-      ? $descriptions[DiffusionCapabilityPush::CAPABILITY]
+      ? $descriptions[DiffusionPushCapability::CAPABILITY]
       : phutil_tag('em', array(), pht('Not a Hosted Repository'));
     $view->addProperty(pht('Pushable By'), $pushable);
 

src/applications/diffusion/controller/DiffusionRepositoryListController.php

@@ -41,7 +41,7 @@ final class DiffusionRepositoryListController extends DiffusionController {
     $crumbs = parent::buildApplicationCrumbs();
 
     $can_create = $this->hasApplicationCapability(
-      DiffusionCapabilityCreateRepositories::CAPABILITY);
+      DiffusionCreateRepositoriesCapability::CAPABILITY);
 
     $crumbs->addAction(
       id(new PHUIListItemView())

src/applications/diffusion/controller/DiffusionRepositoryNewController.php

@@ -1,14 +1,13 @@
 <?php
 
-final class DiffusionRepositoryNewController
-  extends DiffusionController {
+final class DiffusionRepositoryNewController extends DiffusionController {
 
   public function processRequest() {
     $request = $this->getRequest();
     $viewer = $request->getUser();
 
     $this->requireApplicationCapability(
-      DiffusionCapabilityCreateRepositories::CAPABILITY);
+      DiffusionCreateRepositoriesCapability::CAPABILITY);
 
     if ($request->isFormPost()) {
       if ($request->getStr('type')) {

src/applications/diffusion/controller/DiffusionServeController.php

@@ -144,7 +144,7 @@ final class DiffusionServeController extends DiffusionController {
           $can_push = PhabricatorPolicyFilter::hasCapability(
             $viewer,
             $repository,
-            DiffusionCapabilityPush::CAPABILITY);
+            DiffusionPushCapability::CAPABILITY);
           if (!$can_push) {
             if ($viewer->isLoggedIn()) {
               return new PhabricatorVCSResponse(