archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix non-public capabilities in Application edit

Browse Source 
Summary: Ref T603. I nuked this check by accident and neglected to test the negative case.

Test Plan: Saved a non-public policy (Herald Global) and a public policy (Maniphest View).

Reviewers: asherkin, btrahan

Reviewed By: asherkin

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D7278
This commit is contained in:
epriestley
2013-10-09 16:23:36 -07:00
parent e3005fad09
commit c39b10aa7a
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/applications/meta/controller/PhabricatorApplicationEditController.php
View File

@@ -51,11 +51,14 @@ final class PhabricatorApplicationEditController
continue; continue;
} }
$capobj = PhabricatorPolicyCapability::getCapabilityByKey($capability); if ($new == PhabricatorPolicies::POLICY_PUBLIC) {
$capobj = PhabricatorPolicyCapability::getCapabilityByKey(
$capability);
if (!$capobj || !$capobj->shouldAllowPublicPolicySetting()) { if (!$capobj || !$capobj->shouldAllowPublicPolicySetting()) {
// Can't set non-public policies to public. // Can't set non-public policies to public.
continue; continue;
} }
}
$result[$capability] = $new; $result[$capability] = $new;
} }