archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Allow objects to be linked even if they are missing other fields

Browse Source 
Summary: Fixes T5717. Like other partial edits, object links should not be blocked by unrelated missing fields on the object.

Test Plan:
  - Linked two objects.
  - Verified the inverse editor already sets "continue on missing fields" and "continue on no effect".

Reviewers: chad, btrahan, joshuaspence

Reviewed By: joshuaspence

Subscribers: epriestley

Maniphest Tasks: T5717

Differential Revision: https://secure.phabricator.com/D10059
This commit is contained in:
epriestley
2014-07-26 09:47:54 -07:00
parent 1888f61411
commit c75e12038c
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/applications/search/controller/PhabricatorSearchAttachController.php
View File

@@ -106,7 +106,9 @@ final class PhabricatorSearchAttachController
$txn_editor = $object->getApplicationTransactionEditor() $txn_editor = $object->getApplicationTransactionEditor()
->setActor($user) ->setActor($user)
->setContentSourceFromRequest($request); ->setContentSourceFromRequest($request)
->setContinueOnMissingFields(true);
$txn_template = $object->getApplicationTransactionTemplate() $txn_template = $object->getApplicationTransactionTemplate()
->setTransactionType(PhabricatorTransactions::TYPE_EDGE) ->setTransactionType(PhabricatorTransactions::TYPE_EDGE)
->setMetadataValue('edge:type', $edge_type) ->setMetadataValue('edge:type', $edge_type)