Spaces - re-jigger application name for new Spaces application

Summary: got some errors in my sandbox when I updated. this fixes them and I think is the right naming convention.

Test Plan: /settings/panel/emailpreferences/ started working again!  /spaces/ also loaded  unit tests passed without errors

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8377

Differential Revision: https://secure.phabricator.com/D13103

src/applications/spaces/application/PhabricatorSpacesApplication.php

@@ -1,6 +1,6 @@
 <?php
 
-final class PhabricatorApplicationSpaces extends PhabricatorApplication {
+final class PhabricatorSpacesApplication extends PhabricatorApplication {
 
   public function getBaseURI() {
     return '/spaces/';

src/applications/spaces/query/PhabricatorSpacesNamespaceQuery.php

@@ -23,7 +23,7 @@ final class PhabricatorSpacesNamespaceQuery
   }
 
   public function getQueryApplicationClass() {
-    return 'PhabricatorApplicationSpaces';
+    return 'PhabricatorSpacesApplication';
   }
 
   protected function loadPage() {

src/applications/spaces/storage/PhabricatorSpacesNamespace.php

@@ -15,7 +15,7 @@ final class PhabricatorSpacesNamespace
   public static function initializeNewNamespace(PhabricatorUser $actor) {
     $app = id(new PhabricatorApplicationQuery())
       ->setViewer($actor)
-      ->withClasses(array('PhabricatorApplicationSpaces'))
+      ->withClasses(array('PhabricatorSpacesApplication'))
       ->executeOne();
 
     $view_policy = $app->getPolicy(