archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Remarkup unittest result messages

Browse Source 
Summary: This diffs adds support for marking up unittest result messages.

Test Plan: Verified that links in unittest results were markup'd.

Reviewers: epriestley, jungejason

Reviewed By: epriestley

CC: aran, epriestley, zeeg

Differential Revision: https://secure.phabricator.com/D1298
This commit is contained in:
Andrew Gallagher
2012-01-03 00:34:59 -08:00
parent 48f72b57b2
commit cd0386bf8b
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/applications/differential/field/specification/unit/DifferentialUnitFieldSpecification.php
View File

@@ -49,9 +49,9 @@ final class DifferentialUnitFieldSpecification
if ($result != DifferentialUnitTestResult::RESULT_POSTPONED &&
$result != DifferentialUnitTestResult::RESULT_PASS) {
$userdata = phutil_utf8_shorten(idx($test, 'userdata'), 256);
$userdata = phutil_escape_html($userdata);
$userdata = str_replace("\n", '<br />', $userdata);
$engine = PhabricatorMarkupEngine::newDifferentialMarkupEngine();
$userdata = phutil_utf8_shorten(idx($test, 'userdata'), 512);
$userdata = $engine->markupText($userdata);
$unit_messages[] =
'<li>'.

1
src/applications/differential/field/specification/unit/__init__.php
View File

@@ -10,6 +10,7 @@ phutil_require_module('phabricator', 'applications/differential/constants/unitst
phutil_require_module('phabricator', 'applications/differential/constants/unittestresult');
phutil_require_module('phabricator', 'applications/differential/field/specification/base');
phutil_require_module('phabricator', 'applications/differential/view/revisionupdatehistory');
phutil_require_module('phabricator', 'applications/markup/engine');
phutil_require_module('phutil', 'markup');
phutil_require_module('phutil', 'utils');