When setup issues raise opcache configuration errors, point at the opcache configuration page
Summary:
Fixes T11746. The opcache docs are on a different page, so point there if we're raising opcache issues.
(It's possible for a setup issue to say "configure X, or configure Y", where X is opcache and Y is non-opcache, so we may want to render both links.)
Test Plan: {F1867109}
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11746
Differential Revision: https://secure.phabricator.com/D16685
			
			
This commit is contained in:
		| @@ -404,19 +404,48 @@ final class PhabricatorSetupIssueView extends AphrontView { | |||||||
|         implode("\n", $more_loc)); |         implode("\n", $more_loc)); | ||||||
|     } |     } | ||||||
|  |  | ||||||
|     $info[] = phutil_tag( |     $show_standard = false; | ||||||
|       'p', |     $show_opcache = false; | ||||||
|       array(), |  | ||||||
|       pht( |     foreach ($configs as $key) { | ||||||
|         'You can find more information about PHP configuration values in the '. |       if (preg_match('/^opcache\./', $key)) { | ||||||
|         '%s.', |         $show_opcache = true; | ||||||
|         phutil_tag( |       } else { | ||||||
|           'a', |         $show_standard = true; | ||||||
|           array( |       } | ||||||
|             'href' => 'http://php.net/manual/ini.list.php', |     } | ||||||
|             'target' => '_blank', |  | ||||||
|           ), |     if ($show_standard) { | ||||||
|           pht('PHP Documentation')))); |       $info[] = phutil_tag( | ||||||
|  |         'p', | ||||||
|  |         array(), | ||||||
|  |         pht( | ||||||
|  |           'You can find more information about PHP configuration values '. | ||||||
|  |           'in the %s.', | ||||||
|  |           phutil_tag( | ||||||
|  |             'a', | ||||||
|  |             array( | ||||||
|  |               'href' => 'http://php.net/manual/ini.list.php', | ||||||
|  |               'target' => '_blank', | ||||||
|  |             ), | ||||||
|  |             pht('PHP Documentation')))); | ||||||
|  |     } | ||||||
|  |  | ||||||
|  |     if ($show_opcache) { | ||||||
|  |       $info[] = phutil_tag( | ||||||
|  |         'p', | ||||||
|  |         array(), | ||||||
|  |         pht( | ||||||
|  |           'You can find more information about configuring OPCache in '. | ||||||
|  |           'the %s.', | ||||||
|  |           phutil_tag( | ||||||
|  |             'a', | ||||||
|  |             array( | ||||||
|  |               'href' => 'http://php.net/manual/opcache.configuration.php', | ||||||
|  |               'target' => '_blank', | ||||||
|  |             ), | ||||||
|  |             pht('PHP OPCache Documentation')))); | ||||||
|  |     } | ||||||
|  |  | ||||||
|     $info[] = phutil_tag( |     $info[] = phutil_tag( | ||||||
|       'p', |       'p', | ||||||
|   | |||||||
		Reference in New Issue
	
	Block a user
	 epriestley
					epriestley