Highlight lines on drag and drop in Diffusion
Summary: Nobody knows that it's possible to highlight more lines because there's no interface for it. Test Plan: Highlighted: - single line - top to bottom - bottom to top - inside to outside Reviewers: Korvin, epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D3150
This commit is contained in:
@@ -244,10 +244,11 @@ final class DiffusionBrowseFileController extends DiffusionController {
|
||||
));
|
||||
}
|
||||
|
||||
$corpus_table = phutil_render_tag(
|
||||
$corpus_table = javelin_render_tag(
|
||||
'table',
|
||||
array(
|
||||
'class' => "diffusion-source remarkup-code PhabricatorMonospaced",
|
||||
'sigil' => 'diffusion-source',
|
||||
),
|
||||
implode("\n", $rows));
|
||||
$corpus = phutil_render_tag(
|
||||
@@ -592,14 +593,17 @@ final class DiffusionBrowseFileController extends DiffusionController {
|
||||
),
|
||||
phutil_escape_html($line['line']));
|
||||
|
||||
$blame[] = phutil_render_tag(
|
||||
$blame[] = javelin_render_tag(
|
||||
'th',
|
||||
array(
|
||||
'class' => 'diffusion-line-link',
|
||||
'sigil' => 'diffusion-line-link',
|
||||
'style' => isset($color) ? 'background: '.$color : null,
|
||||
),
|
||||
$line_link);
|
||||
|
||||
Javelin::initBehavior('diffusion-line-linker');
|
||||
|
||||
$blame = implode('', $blame);
|
||||
|
||||
if ($line['target']) {
|
||||
@@ -624,7 +628,7 @@ final class DiffusionBrowseFileController extends DiffusionController {
|
||||
$rows[] = phutil_render_tag(
|
||||
'tr',
|
||||
array(
|
||||
'style' => ($line['highlighted'] ? 'background: #ffff00;' : null),
|
||||
'class' => ($line['highlighted'] ? 'highlighted' : null),
|
||||
),
|
||||
$blame.
|
||||
$line_text);
|
||||
|
||||
Reference in New Issue
Block a user