Conpherence - make the JS layer a bit better

Summary: this diff tries to polish the poo out of the JS layer while achieving fixes T3157 accolades.

Test Plan: introduced sleeps in the various controllers and clicked about. verified good "loading" UI in the menu / message / widget section as appropros. Loaded up in device size and resize and desktop sized and resized and all was good.

Reviewers: epriestley

Reviewed By: epriestley

CC: chad, aran, Korvin

Maniphest Tasks: T3164, T3157

Differential Revision: https://secure.phabricator.com/D6069
This commit is contained in:
Bob Trahan
2013-05-29 12:46:06 -07:00
parent 0f070236bd
commit d0b9b6c908
13 changed files with 602 additions and 259 deletions

View File

@@ -70,7 +70,7 @@ final class ConpherenceViewController extends
$form = null;
$content = array('messages' => $messages);
} else {
$header = $this->renderHeaderPaneContent();
$header = $this->buildHeaderPaneContent($conpherence);
$form = $this->renderFormContent($data['latest_transaction_id']);
$content = array(
'header' => $header,
@@ -103,19 +103,10 @@ final class ConpherenceViewController extends
));
}
private function renderHeaderPaneContent() {
$conpherence = $this->getConpherence();
$header = $this->buildHeaderPaneContent($conpherence);
return hsprintf('%s', $header);
}
private function renderMessagePaneContent(
array $transactions,
$oldest_transaction_id) {
require_celerity_resource('conpherence-message-pane-css');
$scrollbutton = '';
if ($oldest_transaction_id) {
$scrollbutton = javelin_tag(