archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Remove completely pointless load of every repository when viewing a repository URI

Browse Source 
Summary:
See D18176. This query has no effect (other than wasting resources) and the result is unused.

`$repository` already has the URI loaded because we load them unconditionally during request initialization.

Test Plan: Viewed repository URIs.

Subscribers: jmeador

Differential Revision: https://secure.phabricator.com/D19036
This commit is contained in:
epriestley
2018-02-08 12:41:11 -08:00
parent 705ff8d33d
commit d1e273daf6
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php
View File

@@ -23,14 +23,10 @@ final class DiffusionRepositoryURIViewController
return new Aphront404Response(); return new Aphront404Response();
} }
// For display, reload the URI by loading it through the repository. This // For display, access the URI by loading it through the repository. This
// may adjust builtin URIs for repository configuration, so we may end up // may adjust builtin URIs for repository configuration, so we may end up
// with a different view of builtin URIs than we'd see if we loaded them // with a different view of builtin URIs than we'd see if we loaded them
// directly from the database. See T12884. // directly from the database. See T12884.
$repository_with_uris = id(new PhabricatorRepositoryQuery())
->setViewer($viewer)
->needURIs(true)
->execute();
$repository_uris = $repository->getURIs(); $repository_uris = $repository->getURIs();
$repository_uris = mpull($repository_uris, null, 'getID'); $repository_uris = mpull($repository_uris, null, 'getID');