Disable Herald more aggressively when it's turned off for a repository
Summary: Currently, disabling Herald only disables feed, notifications and email. Historically, audits didn't really create external effects so it made sense for Herald to only partially disable itself. With the advent of Harbormaster/Build Plans, it makes more sense for Herald to just stop doing anything. When this option is disabled, stop all audit/build/publish/feed/email actions for the repository. Test Plan: Ran `scripts/repository/reparse.php --herald`, etc. Reviewers: dctrwatson, btrahan Reviewed By: btrahan Subscribers: aran, epriestley Differential Revision: https://secure.phabricator.com/D8509
This commit is contained in:
@@ -75,7 +75,8 @@ final class DiffusionRepositoryEditActionsController
|
||||
"Normally, Phabricator publishes notifications when it discovers ".
|
||||
"new commits. You can disable publishing for this repository by ".
|
||||
"turning off **Notify/Publish**. This will disable notifications, ".
|
||||
"feed, and Herald for this repository.".
|
||||
"feed, and Herald (including audits and build plans) for this ".
|
||||
"repository.".
|
||||
"\n\n".
|
||||
"When Phabricator discovers a new commit, it can automatically ".
|
||||
"close associated revisions and tasks. If you don't want ".
|
||||
|
||||
Reference in New Issue
Block a user