Remove sidenav from Workboards

Summary: Visually, I think these are much cleaner (with colors), and provide more workspace. I also don't really use the sidenav here and if I did, it would be to go back to the project homepage. I think this is overall better. If navigation page to project home is difficult or hard to find, we can maybe make a better header / crumbs bar to reduce that.

Test Plan: New project -> basic new board. Existing project -> color board. Desktop, Mobile, Fullscreen

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D16882

resources/celerity/map.php

@@ -165,8 +165,8 @@ return array(
     'rsrc/css/phui/phui-tag-view.css' => '6bbd83e2',
     'rsrc/css/phui/phui-timeline-view.css' => 'bc523970',
     'rsrc/css/phui/phui-two-column-view.css' => 'bbe32c23',
-    'rsrc/css/phui/workboards/phui-workboard-color.css' => 'ac6fe6a7',
+    'rsrc/css/phui/workboards/phui-workboard-color.css' => '207828dd',
-    'rsrc/css/phui/workboards/phui-workboard.css' => 'e09eb53a',
+    'rsrc/css/phui/workboards/phui-workboard.css' => '60d09514',
     'rsrc/css/phui/workboards/phui-workcard.css' => '0c62d7c5',
     'rsrc/css/phui/workboards/phui-workpanel.css' => '92197373',
     'rsrc/css/sprite-login.css' => '6dbbbd97',
@@ -883,8 +883,8 @@ return array(
     'phui-theme-css' => '798c69b8',
     'phui-timeline-view-css' => 'bc523970',
     'phui-two-column-view-css' => 'bbe32c23',
-    'phui-workboard-color-css' => 'ac6fe6a7',
+    'phui-workboard-color-css' => '207828dd',
-    'phui-workboard-view-css' => 'e09eb53a',
+    'phui-workboard-view-css' => '60d09514',
     'phui-workcard-view-css' => '0c62d7c5',
     'phui-workpanel-view-css' => '92197373',
     'phuix-action-list-view' => 'b5c256b8',

src/applications/project/controller/PhabricatorProjectBoardViewController.php

@@ -416,7 +416,6 @@ final class PhabricatorProjectBoardViewController
       ->appendChild($board)
       ->addClass('project-board-wrapper');
 
-    $nav = $this->getProfileMenu();
     $divider = id(new PHUIListItemView())
       ->setType(PHUIListItemView::TYPE_DIVIDER);
     $fullscreen = $this->buildFullscreenMenu();
@@ -439,7 +438,6 @@ final class PhabricatorProjectBoardViewController
         ))
       ->setPageObjectPHIDs(array($project->getPHID()))
       ->setShowFooter(false)
-      ->setNavigation($nav)
       ->setCrumbs($crumbs)
       ->addQuicksandConfig(
         array(

src/applications/project/controller/PhabricatorProjectController.php

@@ -119,7 +119,8 @@ abstract class PhabricatorProjectController extends PhabricatorController {
       foreach ($ancestors as $ancestor) {
         $crumbs->addTextCrumb(
           $ancestor->getName(),
-          $ancestor->getURI());
+          $ancestor->getProfileURI()
+        );
       }
     }
 

src/applications/project/storage/PhabricatorProject.php

@@ -367,6 +367,11 @@ final class PhabricatorProject extends PhabricatorProjectDAO
     return "/project/view/{$id}/";
   }
 
+  public function getProfileURI() {
+    $id = $this->getID();
+    return "/project/profile/{$id}/";
+  }
+
   public function save() {
     if (!$this->getMailKey()) {
       $this->setMailKey(Filesystem::readRandomCharacters(20));

webroot/rsrc/css/phui/workboards/phui-workboard-color.css

@@ -2,10 +2,6 @@
  * @provides phui-workboard-color-css
  */
 
-.phui-workboard-color .phabricator-nav-content .phui-workboard-view-shadow {
-  background-color: transparent;
-}
-
 .phui-workboard-color .phui-crumbs-view {
   background-color: rgba({$alphagrey},.15);
   border: none;
@@ -30,18 +26,6 @@
   background-color: rgba({$alphawhite},.6);
 }
 
-body.phui-workboard-color .phui-profile-menu .phabricator-side-menu {
-  background-color: rgba({$alphagrey},.3);
-}
-
-body.phui-workboard-color .phabricator-side-menu .phui-profile-menu-footer-1 {
-  background-color: transparent;
-}
-
-.phui-workboard-color .phui-profile-menu .phabricator-side-menu {
-  box-shadow: none;
-}
-
 .phui-workboard-color-preview {
   width: 50px;
   height: 50px;

webroot/rsrc/css/phui/workboards/phui-workboard.css

@@ -19,7 +19,6 @@
   left: 0;
   right: 0;
   padding: 16px;
-  background-color: #fff;
 }
 
 .phui-workboard-view-shadow::-webkit-scrollbar {
@@ -32,15 +31,6 @@
   background: {$lightbluetext};
 }
 
-.device-desktop .project-board-wrapper .phui-workboard-view-shadow {
-  left: {$menu.profile.width};
-}
-
-.device-desktop .phui-profile-menu-collapsed .project-board-wrapper
-  .phui-workboard-view-shadow {
-  left: {$menu.profile.width.collapsed};
-}
-
 !print .project-board-wrapper .phui-workboard-view-shadow {
   position: static;
 }
@@ -75,8 +65,7 @@
   display: none;
 }
 
-.device-desktop .phui-workboard-fullscreen .phui-profile-menu
+.device-desktop .phui-workboard-fullscreen .phui-workboard-view-shadow {
-  .phui-workboard-view-shadow {
   top: 35px;
   left: 0;
 }
@@ -85,11 +74,6 @@
   max-height: calc(100vh - 120px);
 }
 
-.device-desktop .phui-workboard-fullscreen .phui-profile-menu
-  .phabricator-nav-local {
-    display: none;
-}
-
 .device .phui-workboard-expand-icon {
   display: none;
 }