Convert all tokenizers to take token/scalar inputs

Summary: Ref T7689. Ref T4100. This advances the goals of removing `loadViewerHandles()` (only 67 callsites remain!) and letting tokenizers some day take token functions like `viewer()` and `members(differential)`.

Test Plan:
- Sent a new message; used "To".
  - I simplified the cancel URI construction slightly because it's moot in all normal cases.
- Edited a thread; used "Add Participants".
- Searched rooms; used "Participants".
- Searched countdowns; used "Authors".
- Created a diff; used "Repository".
- Edited a revision; edited "Projects"; edited "Reveiwers"; edited "Subscribers".
- Searched for revisions; edited "responsible users"; "authors"; "reviwers"; "subscribers"; "repositories".
- Added revision comments; edited "Add Reveiwers"; "Add Subscribers".
- Commented on a commit; edited "Add Auditors"; "Add subscribers".
- Edited a commit; edited "Projects".
- Edited a repository; edited "Projects".
- Searched feed, used "include Users"; "include Proejcts".
- Searched files, used "authors".
- Edited initiative; edited "Projects".
- Searched backers; used "Backers".
- Searched initiatives; used "Owners".
- Edited build plans; edited "Run Command".
- Searched Herald; used "Authors".
- Added signature exemption in Legalpad.
- Searhced legalpad; used "creators"; used "contributors".
- Searched signatures; used "documents"; used "signers".
- Created meme.
- Searched macros; used "Authors".
- Used "Projects" in Maniphest reports.
- Used Maniphest comment actions.
- Edited Maniphest tasks; edited "Assigned To"; edited "CC"; edited "projects".
- Used "parent" in Maniphest task creation workflow.
- Searched for projects; used "assigned to"; "in any projec"; "in all projects"; "not in projects"; "in users' projects"; "authors"; "subscribers".
- Edited Maniphest bug filing domains, used "Default Author".
- Searched for OAuth applications, used "Creators".
- Edited Owners pacakge; edited "Primary Owner"; edited "Owners".
- Searched for Owners packages; used "Owner".
  - OMG this UI is OLD
- Edited a paste; edited "Projects".
- Searched for paste; used "Authors".
- Searched user activity log; used "Actors"; used "Users".
- Edited a mock; edited "Projects"; edited "CC".
- Searched for mocks; used "Authors".
- Edited Phortune account; edited "Members".
- Edited Phortune merchant account; edited "Members".
- Searched Phrequent; used "Users".
- Edited Ponder question; sued "projects".
- Searched Ponder; used "Authors"; used "Answered By".
- Added project members.
- Searched for projects; used "Members".
- Edited a Releeph product; edited "Pushers".
- Searched pull requests; searched "Requestors".
- Edited an arcanist project; used "Uses Symbols From".
- Searhced push logs; used "Repositories"; used "Pushers".
- Searched repositories; used "In nay project".
- Used global search; used Authors/owners/Subscribers/In Any Project.
- Edited a slowvote; used "Projects".
- Searched slovotes; used "Authors".
- Created a custom "Users" field; edited and searched for it.
- Made a whole lot of typos in this list. ^^^^^^

Did not test:

- Lint is nontrivial to test locally, I'll test it in production.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4100, T7689

Differential Revision: https://secure.phabricator.com/D12224

src/applications/differential/controller/DifferentialDiffCreateController.php

@@ -28,7 +28,6 @@ final class DifferentialDiffCreateController extends DifferentialController {
     // This object is just for policy stuff
     $diff_object = DifferentialDiff::initializeNewDiff($viewer);
     $repository_phid = null;
-    $repository_value = array();
     $errors = array();
     $e_diff = null;
     $e_file = null;
@@ -62,7 +61,8 @@ final class DifferentialDiffCreateController extends DifferentialController {
             array(
               'diff' => $diff,
               'repositoryPHID' => $repository_phid,
-              'viewPolicy' => $request->getStr('viewPolicy'),));
+              'viewPolicy' => $request->getStr('viewPolicy'),
+            ));
           $call->setUser($viewer);
           $result = $call->execute();
 
@@ -93,10 +93,6 @@ final class DifferentialDiffCreateController extends DifferentialController {
 
     $cancel_uri = $this->getApplicationURI();
 
-    if ($repository_phid) {
-      $repository_value = $this->loadViewerHandles(array($repository_phid));
-    }
-
     $policies = id(new PhabricatorPolicyQuery())
       ->setViewer($viewer)
       ->setObject($diff_object)
@@ -148,6 +144,12 @@ final class DifferentialDiffCreateController extends DifferentialController {
           ->setValue($revision_handle->renderLink()));
     }
 
+    if ($repository_phid) {
+      $repository_value = array($repository_phid);
+    } else {
+      $repository_value = array();
+    }
+
     $form
       ->appendChild(
         id(new AphrontFormTextAreaControl())
@@ -161,20 +163,20 @@ final class DifferentialDiffCreateController extends DifferentialController {
           ->setLabel(pht('Raw Diff From File'))
           ->setName('diff-file')
           ->setError($e_file))
-      ->appendChild(
+      ->appendControl(
         id(new AphrontFormTokenizerControl())
-        ->setName(id(new DifferentialRepositoryField())->getFieldKey())
-        ->setLabel(pht('Repository'))
-        ->setDatasource(new DiffusionRepositoryDatasource())
-        ->setValue($repository_value)
-        ->setLimit(1))
+          ->setName(id(new DifferentialRepositoryField())->getFieldKey())
+          ->setLabel(pht('Repository'))
+          ->setDatasource(new DiffusionRepositoryDatasource())
+          ->setValue($repository_value)
+          ->setLimit(1))
       ->appendChild(
         id(new AphrontFormPolicyControl())
-        ->setUser($viewer)
-        ->setName('viewPolicy')
-        ->setPolicyObject($diff_object)
-        ->setPolicies($policies)
-        ->setCapability(PhabricatorPolicyCapability::CAN_VIEW))
+          ->setUser($viewer)
+          ->setName('viewPolicy')
+          ->setPolicyObject($diff_object)
+          ->setPolicies($policies)
+          ->setCapability(PhabricatorPolicyCapability::CAN_VIEW))
       ->appendChild(
         id(new AphrontFormSubmitControl())
           ->addCancelButton($cancel_uri)