archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Never hide file contents if they have comments.

Browse Source 
Summary:
Links to comments were not working because file was hidden after it was deleted.

Test Plan:
Tested that comment anchors were working correctly for deleted files.
Tested that generated files were still hidden.

Reviewed By: epriestley
Reviewers: epriestley
CC: jungejason, aran, epriestley
Differential Revision: 257
This commit is contained in:
tuomaspelkonen
2011-05-09 17:47:12 -07:00
parent e313b1d64a
commit d5dfa5faf5
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/applications/differential/parser/changeset/DifferentialChangesetParser.php
View File

@@ -816,7 +816,7 @@ EOSYNTHETIC;
} }
$shield = null; $shield = null;
if ($range_start === null && $range_len === null) { if ($range_start === null && $range_len === null && !$this->comments) {
if ($this->isGenerated()) { if ($this->isGenerated()) {
$shield = $this->renderShield( $shield = $this->renderShield(
"This file contains generated code, which does not normally need ". "This file contains generated code, which does not normally need ".