archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Don't set a default "group by priority" in the task search engine

Browse Source 
Summary:
See PHI42. Currently, `maniphest.search` incorrectly applies this default (group by priority) to all queries via Conduit.

The correct behavior is to apply no grouping constraint.

I think this is also a reasonable general behavior, and the current code seems to date from D6960 in 2013 and didn't seem particularly carefully considered.

This is a minor compatibility break -- saved queries which are more than 4 years old might change their group behavior. I'll note this in the change logs but expect essentially no one to be affected.

Test Plan: Ran a `maniphest.search` Conduit call and observed the underlying query. Before this change, it executed `ORDER BY priority, id`. After this change, it correctly executed `ORDER BY id` only.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D18459
This commit is contained in:
epriestley
2017-08-24 05:58:16 -07:00
parent 66613240fa
commit d6e47eef19
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/applications/maniphest/query/ManiphestTaskSearchEngine.php
View File

@@ -236,8 +236,6 @@ final class ManiphestTaskSearchEngine
$group = idx($this->getGroupValues(), $group); $group = idx($this->getGroupValues(), $group);
if ($group) { if ($group) {
$query->setGroupBy($group); $query->setGroupBy($group);
} else {
$query->setGroupBy(head($this->getGroupValues()));
} }
if ($map['ids']) { if ($map['ids']) {