Display revision number in history

Test Plan:
Displayed repository.
Displayed repository history.
Wondered that we actually have bunch of commits without a revision.
Displayed blame.
Didn't display merge commit.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D2840
This commit is contained in:
vrana
2012-06-22 16:52:08 -07:00
parent 969dcc5bae
commit d7b8bc892b
7 changed files with 52 additions and 13 deletions

View File

@@ -388,20 +388,13 @@ final class DiffusionBrowseFileController extends DiffusionController {
$commits = mpull($commits, null, 'getCommitIdentifier');
}
$revision_ids = array();
$revision_ids = id(new DifferentialRevision())
->loadIDsByCommitPHIDs(mpull($commits, 'getPHID'));
$revisions = array();
if ($commits) {
$revision_ids = queryfx_all(
id(new DifferentialRevision())->establishConnection('r'),
'SELECT * FROM %T WHERE commitPHID IN (%Ls)',
DifferentialRevision::TABLE_COMMIT,
mpull($commits, 'getPHID'));
if ($revision_ids) {
$revision_ids = ipull($revision_ids, 'revisionID', 'commitPHID');
$revisions = id(new DifferentialRevision())->loadAllWhere(
'id IN (%Ld)',
$revision_ids);
}
if ($revision_ids) {
$revisions = id(new DifferentialRevision())->loadAllWhere(
'id IN (%Ld)',
$revision_ids);
}
$request = $this->getRequest();