Update Differential edit pages to new UI
Summary: Updates using PHUITwoColumnView, new headers, etc. Test Plan: New Diff, Update Diff, View Standalone pages, Edit pages. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15549
This commit is contained in:
@@ -124,10 +124,12 @@ final class DifferentialDiffCreateController extends DifferentialController {
|
||||
$title = pht('Update Diff');
|
||||
$header = pht('Update Diff');
|
||||
$button = pht('Continue');
|
||||
$header_icon = 'fa-upload';
|
||||
} else {
|
||||
$title = pht('Create Diff');
|
||||
$header = pht('Create New Diff');
|
||||
$button = pht('Create Diff');
|
||||
$header_icon = 'fa-plus-square';
|
||||
}
|
||||
|
||||
$form
|
||||
@@ -180,15 +182,12 @@ final class DifferentialDiffCreateController extends DifferentialController {
|
||||
->setValue($button));
|
||||
|
||||
$form_box = id(new PHUIObjectBoxView())
|
||||
->setHeaderText($header)
|
||||
->setHeaderText(pht('Diff'))
|
||||
->setValidationException($validation_exception)
|
||||
->setForm($form)
|
||||
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
|
||||
->setFormErrors($errors);
|
||||
|
||||
if ($info_view) {
|
||||
$form_box->setInfoView($info_view);
|
||||
}
|
||||
|
||||
$crumbs = $this->buildApplicationCrumbs();
|
||||
if ($revision) {
|
||||
$crumbs->addTextCrumb(
|
||||
@@ -196,15 +195,23 @@ final class DifferentialDiffCreateController extends DifferentialController {
|
||||
'/'.$revision->getMonogram());
|
||||
}
|
||||
$crumbs->addTextCrumb($title);
|
||||
$crumbs->setBorder(true);
|
||||
|
||||
return $this->buildApplicationPage(
|
||||
array(
|
||||
$crumbs,
|
||||
$header = id(new PHUIHeaderView())
|
||||
->setHeader($title)
|
||||
->setHeaderIcon($header_icon);
|
||||
|
||||
$view = id(new PHUITwoColumnView())
|
||||
->setHeader($header)
|
||||
->setFooter(array(
|
||||
$info_view,
|
||||
$form_box,
|
||||
),
|
||||
array(
|
||||
'title' => $title,
|
||||
));
|
||||
|
||||
return $this->newPage()
|
||||
->setTitle($title)
|
||||
->setCrumbs($crumbs)
|
||||
->appendChild($view);
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user