Add 'viewer' to some Remarkup callsites

Summary:
I want to implement a `{P123}` rule to embed pastes, but we need viewers everywhere before it will work with privacy.

This is not exhaustive; many Remarkup callsites haven't been converted to `PhabricatorMarkupInterface` yet.

Test Plan: Looked at Maniphest, Differential, Diffusion, Phriction; added markup, made edits and hit previews.

Reviewers: vrana, btrahan

Reviewed By: vrana

CC: aran

Differential Revision: https://secure.phabricator.com/D3428

src/applications/maniphest/controller/ManiphestTaskDescriptionChangeController.php

@@ -64,6 +64,7 @@ final class ManiphestTaskDescriptionChangeController
     $handles = $this->loadViewerHandles($phids);
 
     $engine = new PhabricatorMarkupEngine();
+    $engine->setViewer($user);
     $engine->addObject($transaction, ManiphestTransaction::MARKUP_FIELD_BODY);
     $engine->process();
 

src/applications/maniphest/controller/ManiphestTaskDescriptionPreviewController.php

@@ -23,7 +23,6 @@ final class ManiphestTaskDescriptionPreviewController
   extends ManiphestController {
 
   public function processRequest() {
-
     $request = $this->getRequest();
     $description = $request->getStr('description');
 
@@ -32,7 +31,8 @@ final class ManiphestTaskDescriptionPreviewController
 
     $output = PhabricatorMarkupEngine::renderOneObject(
       $task,
-      ManiphestTask::MARKUP_FIELD_DESCRIPTION);
+      ManiphestTask::MARKUP_FIELD_DESCRIPTION,
+      $request->getUser());
 
     $content =
       '<div class="phabricator-remarkup">'.

src/applications/maniphest/controller/ManiphestTaskDetailController.php

@@ -314,6 +314,7 @@ final class ManiphestTaskDetailController extends ManiphestController {
     $headsup_panel->setProperties($dict);
 
     $engine = new PhabricatorMarkupEngine();
+    $engine->setViewer($user);
     $engine->addObject($task, ManiphestTask::MARKUP_FIELD_DESCRIPTION);
     foreach ($transactions as $xaction) {
       if ($xaction->hasComments()) {

src/applications/maniphest/controller/ManiphestTransactionPreviewController.php

@@ -119,6 +119,7 @@ final class ManiphestTransactionPreviewController extends ManiphestController {
     $transactions[] = $transaction;
 
     $engine = new PhabricatorMarkupEngine();
+    $engine->setViewer($user);
     $engine->addObject($transaction, ManiphestTransaction::MARKUP_FIELD_BODY);
     $engine->process();