archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Reorder "Merge" transaction to make "Close as Duplicate" produce a "[Merged]" email subject

Browse Source 
Summary:
Fixes T11782. When you "Close as Duplicate", generate a "[Merged]" email by making the merge the first transaction.

(There are other, more-deterministic ways to do this with action strength, but this is much simpler and I believe it suffices.)

Test Plan: Used "Close as Duplicate", got a "[Merged]" email out of it.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T11782

Differential Revision: https://secure.phabricator.com/D19972
This commit is contained in:
epriestley
2019-01-14 14:32:01 -08:00
parent 35f0e31ed3
commit dc4d7f1f3e
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/applications/maniphest/relationship/ManiphestTaskRelationship.php
View File

@@ -31,13 +31,12 @@ abstract class ManiphestTaskRelationship
$subscriber_phids = $this->loadMergeSubscriberPHIDs($tasks); $subscriber_phids = $this->loadMergeSubscriberPHIDs($tasks);
$xactions[] = id(new ManiphestTransaction()) $xactions[] = id(new ManiphestTransaction())
->setTransactionType(PhabricatorTransactions::TYPE_SUBSCRIBERS) ->setTransactionType(ManiphestTaskMergedFromTransaction::TRANSACTIONTYPE)
->setNewValue(array('+' => $subscriber_phids)); ->setNewValue(mpull($tasks, 'getPHID'));
$xactions[] = id(new ManiphestTransaction()) $xactions[] = id(new ManiphestTransaction())
->setTransactionType( ->setTransactionType(PhabricatorTransactions::TYPE_SUBSCRIBERS)
ManiphestTaskMergedFromTransaction::TRANSACTIONTYPE) ->setNewValue(array('+' => $subscriber_phids));
->setNewValue(mpull($tasks, 'getPHID'));
return $xactions; return $xactions;
} }